From: SourceForge.net <no...@so...> - 2012-07-31 17:12:36
|
Bugs item #3551802, was opened at 2012-07-29 22:00 Message generated for change (Comment added) made by jenglish You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=3551802&group_id=12997 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 32. Key Symbols Group: current: 8.5.12 Status: Closed Resolution: Fixed Priority: 3 Private: No Submitted By: Stuart Cassoff (stwo) Assigned to: Donal K. Fellows (dkf) Summary: XKeycodeToKeysym is deprecated Initial Comment: Building Tk 8.5.12 results in a handful of compiler warnings stating that XKeycodeToKeysym is deprecated, all in unix/tkUnixKey.c. Here's a naive patch that passes the tests. I have no idea what is the correct thing to do here. ---------------------------------------------------------------------- >Comment By: Joe English (jenglish) Date: 2012-07-31 10:12 Message: ... also, from a quick scan of the xkblib manual, if we're going to take a dependency on Xkb (limiting Tk to X11R6.1 and higher, BTW), it looks like a lot of the current adhoccery can be greatly simplified; Xkb has built-in support for much of what Tk does "by hand" now. ---------------------------------------------------------------------- Comment By: Joe English (jenglish) Date: 2012-07-31 10:06 Message: > but the documentation is *terrible* > and the patches to other code out there are no better. > (So, situation normal for X11 API functions.) This looks fairly comprehensive: http://www.x.org/wiki/XKB (first hit when googling "Xkb"). See in particular: http://www.x.org/releases/current/doc/libX11/XKB/xkblib.html ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2012-07-31 07:48 Message: Because the Xkb API appears to be implemented in libX11, I've not added any extra ifdeffery. Code might still not be correct, but we've little hope of correcting it. ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2012-07-30 03:26 Message: The availability of the API looks good, and the header is the correct one. What's not clear is whether setting the group parameter to 0 is always correct; I suspect it isn't, but the documentation is *terrible* and the patches to other code out there are no better. (So, situation normal for X11 API functions.) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=3551802&group_id=12997 |