Menu
▾
▴
[Tcl-bugs] [ tcl-Feature Requests-3544967 ] Missing objectfiles in static lib
|
From: SourceForge.net <no...@so...> - 2012-07-31 11:48:56
|
Feature Requests item #3544967, was opened at 2012-07-17 01:55 Message generated for change (Comment added) made by nijtmans You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=3544967&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 50. Embedding Support Group: None >Status: Pending >Resolution: Fixed Priority: 5 Private: No Submitted By: Decoster Jos (decosterjos) Assigned to: Jan Nijtmans (nijtmans) Summary: Missing objectfiles in static lib Initial Comment: When building a static tclsh and .lib using makefile.vc, the dde and registry code is not added to the .lib. The attached patch adds those object files to the static .lib. Aa a side question: what should be done with tclOOStubLib.obj, tclStubLib.obj and tclTomMathStubLib.obj when building a static .lib with makefile.vc? Should they be added to the .lib too? ---------------------------------------------------------------------- >Comment By: Jan Nijtmans (nijtmans) Date: 2012-07-31 04:48 Message: Merged to trunk now. > (Anyway, I want to wait on Tcl 8.6b3 before doing that, > preventing any risk on delay for the b3 release) It works well, with minimal risk, and doing this now gives more time for testing for the b3 release. Since there are other test failures being investigated now, I don't think this will delay 8.6b3. ---------------------------------------------------------------------- Comment By: Decoster Jos (decosterjos) Date: 2012-07-18 01:51 Message: I understand. I appreciate your support. ---------------------------------------------------------------------- Comment By: Jan Nijtmans (nijtmans) Date: 2012-07-18 01:42 Message: Well, I'm not 100% satisfied yet. If we put tclWinReg.obj and tclWinDde.obj in the static lib using makefile.vc, we should do the same with Makefile.in as well. committed that to frq-3544967 now, with some comment updates in makefile.vc. Still needs more testing before being merge to trunk. (Anyway, I want to wait on Tcl 8.6b3 before doing that, preventing any risk on delay for the b3 release) ---------------------------------------------------------------------- Comment By: Decoster Jos (decosterjos) Date: 2012-07-17 23:56 Message: Tested OK for me. ---------------------------------------------------------------------- Comment By: Jan Nijtmans (nijtmans) Date: 2012-07-17 23:36 Message: Committed to frq-3544967 branch for testing ---------------------------------------------------------------------- Comment By: Decoster Jos (decosterjos) Date: 2012-07-17 23:32 Message: OK, thanks. About the *stub* file: I was only asking as I was not sure when they are needed. It's OK not to have them in the static lib for me. ---------------------------------------------------------------------- Comment By: Jan Nijtmans (nijtmans) Date: 2012-07-17 23:27 Message: So, let's make it a feature request ;-) Actually, I don't have a problem really with putting tclWinReg.o and tclWinDde.o in the static library when OPTS=staticpkgs is specified. However putting the tcl*StubLib.obj files in it is problematic! This means that there are multiple static libraries with the same symbols. This means that you should distribute two static libraries (the normal one and the stub library) to your clients, both should be linked against is dde and registry functionality is desired. Would that work for you? ---------------------------------------------------------------------- Comment By: Decoster Jos (decosterjos) Date: 2012-07-17 23:05 Message: Feature or bug, I perceive it as a bug in the way I need the lib to be built so I can distribute it. Without this change, I'd need to ship the lib and some .obj files or make the change to the makefile after each release. I don't see much use for having the dde and registry .obj not in the .lib. ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2012-07-17 11:54 Message: The *only* purpose of the *StubLib files is to allow an external piece of code to connect to Tcl's API (or the API one of the built-in extensions). Code that's "inside" Tcl (in the same executable) doesn't need stubs; it should be directly bound. There's no point at all in building the *StubLib objects into a Tcl executable; they're just for extension DLLs. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2012-07-17 08:20 Message: Apologies. I overlooked the "StubLib" part of those filenames. ---------------------------------------------------------------------- Comment By: Jan Nijtmans (nijtmans) Date: 2012-07-17 07:52 Message: In Tcl 8.5's makefile.vc I see: TCLSHOBJS = \ $(TMP_DIR)\tclAppInit.obj \ !if $(TCL_USE_STATIC_PACKAGES) $(TMP_DIR)\tclWinReg.obj \ $(TMP_DIR)\tclWinDde.obj \ !endif $(TMP_DIR)\tclsh.res To me that means that OPTS=staticpkgs means that the registry and dde packages should be added to tclsh.exe, not to tclsh85.lib. Changing that would be a feature request, not a bug. ---------------------------------------------------------------------- Comment By: Decoster Jos (decosterjos) Date: 2012-07-17 07:29 Message: I ship tcl86.lib to customers, having everything in one lib is far easier. Why add it to tclsh and not to the lib? For me OPTS=staticpkgs hints at non-loadable packages present in the lib, not just the tclsh. ---------------------------------------------------------------------- Comment By: Jan Nijtmans (nijtmans) Date: 2012-07-17 07:23 Message: tclOOStubLib.obj, tclStubLib.obj and tclTomMathStubLib.obj are in the stub library tcl86stub.lib. Previously they were in the static library as well, but not any more since 8.6. That's on purpose! Applications linking with OPTS=staticpkg still can load dde/registry dynamically, or include it in the build. If you want the latter, you can just add tclWinDde.o, tclWinReg.o and tclstub86.lib to the link line, then you have everything. Would that work for you? ---------------------------------------------------------------------- Comment By: Decoster Jos (decosterjos) Date: 2012-07-17 06:36 Message: When building with OPTS=staticpkg dde and registry are linked into the tclsh, but should also be in the tcl86.lib to make it possible to embed Tcl into an app with Tcl statically linked, including dde and registry. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2012-07-17 06:31 Message: dde and registry are [load]able packages. Not clear to me why their code ought to be in a static Tcl library. The other things you mention have dev history as packages, but they are now simply part of Tcl. Need to be in the Tcl library. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=360894&aid=3544967&group_id=10894 |