[Tcl-bugs] [ tktoolkit-Bugs-3497848 ] GetPixelsFromObjEx error for doubleObjs

[SourceForge.net <no...@so...>]

Bugs item #3497848, was opened at 2012-03-06 10:30
Message generated for change (Tracker Item Submitted) made by ralfixx
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=112997&aid=3497848&group_id=12997

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 27. Objects
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Ralf Fassel (ralfixx)
Assigned to: Jeffrey Hobbs (hobbs)
Summary: GetPixelsFromObjEx error for doubleObjs

Initial Comment:
    % info patchlevel
    8.5.11
    % canvas .c
    .c
    % set x 573.8
    573.8
    % .c canvasx $x
    574.0
    % set x [expr $x+0.0]
    573.8
    % .c canvasx $x
    573.0

Note how the first result 574 differs from the second 573.

this is due to the code in tkObj.c which converts numbers to pixels
and does a rounding in one case and none in the other:

tk/generic/tkObj.c, static int GetPixelsFromObjEx(...), 

   #206ff
    if (objPtr->typePtr != &pixelObjType) {
	ThreadSpecificData *tsdPtr = GetTypeCache();

	if (objPtr->typePtr == tsdPtr->doubleTypePtr) {
	    (void) Tcl_GetDoubleFromObj(interp, objPtr, &d);
	    if (dblPtr != NULL) {
		*dblPtr = d;
	    }
	    *intPtr = (int) d;
	    return TCL_OK;
            
Note this simply casts the double to int, no rounding.

However, in the same routine, if the obj is not double or int:

    if (objPtr->typePtr != &pixelObjType) {
	result = SetPixelFromAny(interp, objPtr);
     ...
     if ((pixelPtr->tkwin != tkwin)||dblPtr) {
	    d = pixelPtr->value;
     --<snip-snip>--
	    if (d < 0) {
		pixelPtr->returnValue = (int) (d - 0.5);
	    } else {
		pixelPtr->returnValue = (int) (d + 0.5);
	    }
    --<snip-snip>--
	}
	*intPtr = pixelPtr->returnValue;

Note the rounding in this case.

Proposed patch:

This seems to be related to
    2011-11-01  Donal K. Fellows  <dk...@us...>
            * generic/tkObj.c (GetPixelsFromObjEx): [Bug 3431491]: Use a bit of
            type hackery to allow numbers to be interpreted as coordinates (most
            notably on a canvas) without reinterpreting via a string.

Proposed patch:

--- tk/generic/tkObj.c	2011/11/08 14:59:18	1.1
+++ tk/generic/tkObj.c	2012/03/06 18:15:36
@@ -211,7 +211,11 @@
 	    if (dblPtr != NULL) {
 		*dblPtr = d;
 	    }
-	    *intPtr = (int) d;
+	    if (d < 0) {
+		*intPtr = (int) (d - 0.5);
+	    } else {
+		*intPtr = (int) (d + 0.5);
+	    }
 	    return TCL_OK;
 	} else if (objPtr->typePtr == tsdPtr->intTypePtr) {
 	    (void) Tcl_GetIntFromObj(interp, objPtr, intPtr);


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=112997&aid=3497848&group_id=12997