From: SourceForge.net <no...@so...> - 2010-09-20 21:19:28
|
Patches item #3072080, was opened at 2010-09-20 20:41 Message generated for change (Comment added) made by ferrieux You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=3072080&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 45. Parsing and Eval Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: miguel sofer (msofer) Assigned to: miguel sofer (msofer) Summary: a saner NRE Initial Comment: Attached a patch that removes all NRE duties from TEBC: it is a relatively big redesign of the NRE main loop. The original NRE implementation has TclNRRunCallbacks (TNRRC) and TEBC work in tandem, working hard to reuse TEBC instances. The design is at the root of a very complicated logic flow within TEBC and elsewhere. This patch removes the special NRE status from TEBC. The main advantage is that the logic is much simpler (both within TEBC and elsewhere), leading to enhanced maintainability. I would appreciate more thorough testing (and perf impact estimates?) before committing this patch. ---------------------------------------------------------------------- >Comment By: Alexandre Ferrieux (ferrieux) Date: 2010-09-20 23:19 Message: Also, var.test panics on my system (unix threaded, nondebug): Test file error: TclStackFree: incorrect freePtr (0x8421f48 != 0x8421f3f). Call out of sequence? ---------------------------------------------------------------------- Comment By: Alexandre Ferrieux (ferrieux) Date: 2010-09-20 22:40 Message: Attaching perf measurements with the "10-bench + spacer" technique. The first four columns are normalized times. First line headers give the names: - tcl86 == vanilla HEAD - tcl86foo == HEAD + 16-byte foo spacer at beginning of regcomp.o - tcl86sn == HEAD + Saner Nre patch - tcl86snfoo == both File sorted on column 3, which is tcl86sn time. Bottom line: hard to summarize... range is roughly +-12%, though near both extremes the foo-spacer wipes the effect. Tough... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=3072080&group_id=10894 |