[Tcl-bugs] [ tcl-Patches-3009403 ] Signature of Tcl_GetHashKey, Tcl_(Create|Find)HashEntry

[SourceForge.net <no...@so...>]

Patches item #3009403, was opened at 2010-05-31 11:49
Message generated for change (Comment added) made by nijtmans
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=310894&aid=3009403&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 52. Portability Support
Group: None
Status: Open
>Resolution: Fixed
Priority: 3
Private: No
Submitted By: Jan Nijtmans (nijtmans)
Assigned to: miguel sofer (msofer)
Summary: Signature of Tcl_GetHashKey, Tcl_(Create|Find)HashEntry

Initial Comment:
The signatures of those functions use "char *" resp.
"const char *" in their signatures. However, keys in
hash tables, can be anything, so using "char" here
means that type casts are needed in many current
code using hash tables.

At first sight, this might seem a binary incompatible
change to change this , because on some platforms
"char *" does not have the same size as "void *".
However, those 3 functions are in reality macros
defined in tcl.h, which eventuall call functions
whose signature is not changed. So: this
change is 100% source and binary compatible!

Here is the suggested patch.

Because Tcl_(Create|Find)HashEntry is in the
stub table, (but cannot actually be used, see
Bug #3007895), this patch is better used
in combination with #3007895. Otherwise
people might wonder why the signatures
of those stub table entries don't match the
doc and the macros.

----------------------------------------------------------------------

>Comment By: Jan Nijtmans (nijtmans)
Date: 2010-08-14 22:59

Message:
signature change checked in HEAD

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=310894&aid=3009403&group_id=10894