[Tcl-bugs] [ tcl-Bugs-3007895 ] Tcl_(Find|Create)HashEntry stub entries can never be called

[SourceForge.net <no...@so...>]

Bugs item #3007895, was opened at 2010-05-27 12:00
Message generated for change (Comment added) made by dkf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3007895&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 10. Objects
Group: None
Status: Open
Resolution: None
>Priority: 4
Private: No
Submitted By: Jan Nijtmans (nijtmans)
>Assigned to: miguel sofer (msofer)
Summary: Tcl_(Find|Create)HashEntry stub entries can never be called

Initial Comment:
>From tcl.h we can see that Tcl_(Find|Create)HashEntry
is a macro, but it is in the stub table as well. The macro
overrides the definition in tclDecls.h:
=========================================
#undef  Tcl_FindHashEntry
#define Tcl_FindHashEntry(tablePtr, key) ...
#undef  Tcl_CreateHashEntry
#define Tcl_CreateHashEntry(tablePtr, key, newPtr) ...
=========================================
So, the stub table entries are useless. The only effects
it has is:
- Need tricks like #undef, to make tclHash.c and
  tclInitStubs.c compile.
- Tcl_(Find|Create)HashEntry could be static in tclHash.c,
  but only for the stub table they are made EXTERN

Solution: remove those two functions from the stub
table, and we can remove all remaining trickery.

----------------------------------------------------------------------

>Comment By: Donal K. Fellows (dkf)
Date: 2010-05-27 14:44

Message:
Just leave it alone, Jan. You're not the area maintainer.

----------------------------------------------------------------------

Comment By: Jan Nijtmans (nijtmans)
Date: 2010-05-27 12:05

Message:
Another benifit: Making Tcl_(Find|Create)HashEntry
static means that the dynamic loader has two less
symbols which need to be resolved.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=3007895&group_id=10894