Menu
▾
▴
[Tcl-bugs] [ tcl-Bugs-2871908 ] leaking two hashtables and some data in tclObj.c
|
From: SourceForge.net <no...@so...> - 2009-10-07 23:12:33
|
Bugs item #2871908, was opened at 2009-10-02 09:59 Message generated for change (Comment added) made by andreas_kupries You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=2871908&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 10. Objects Group: current: 8.5.7 >Status: Closed >Resolution: Fixed Priority: 9 Private: No Submitted By: Joe Mistachkin (mistachkin) >Assigned to: Andreas Kupries (andreas_kupries) Summary: leaking two hashtables and some data in tclObj.c Initial Comment: The lineCLPtr hashtable structure is being leaked. The entire objThreadMap hashtable and its contained data are also being leaked. This bug also applies to the 8.5 branch. ---------------------------------------------------------------------- >Comment By: Andreas Kupries (andreas_kupries) Date: 2009-10-07 16:12 Message: Applied patch to head and 8.5 branches. Please check in your environ that the leaks are gone. My system passes testsuite before and after. ---------------------------------------------------------------------- Comment By: Andreas Kupries (andreas_kupries) Date: 2009-10-07 15:43 Message: Review patch ... Looks ok, after some thinking. Agreed, applies to 8.5 as well. 8.5 actually has the whole TclFinalizeThreadObjects() function missing. Patch applies ok, modulo ChangeLog entry. I see no test cases however. How can I check the leak from the testsuite ? ---------------------------------------------------------------------- Comment By: Joe Mistachkin (mistachkin) Date: 2009-10-04 14:46 Message: Attached initial patch. Sorry for the previous blank comment, SF UI is acting weird. ---------------------------------------------------------------------- Comment By: Joe Mistachkin (mistachkin) Date: 2009-10-04 14:44 Message: ---------------------------------------------------------------------- Comment By: Alexandre Ferrieux (ferrieux) Date: 2009-10-02 12:57 Message: Can you describe the code path you are considering ? Are you calling Tcl_Exit or Tcl_Finalize ? Remember that since the exit reform of 2001201, Tcl_Exit only calls the finalizer of the calling thread. Another way of missing a finalizer in Tcl_Exit, even if no extra threads are created, is the test on currentAppExitPtr. Can you say which scenario you are reporting ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=2871908&group_id=10894 |