From: SourceForge.net <no...@so...> - 2009-07-14 20:49:03
|
Bugs item #2328657, was opened at 2008-11-22 21:31 Message generated for change (Comment added) made by ferrieux You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=2328657&group_id=12997 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 05. Canvas Items Group: obsolete: 8.6a4 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Don Porter (dgp) Assigned to: Alexandre Ferrieux (ferrieux) Summary: test failures Initial Comment: not certain, but I think these are new: ==== canvText-18.1 bug fix 2525, find enclosed on text with newlines FAILED ==== Contents of test case: pack [canvas .c] .c create text 100 100 -text Hello\n -anchor nw set bbox [.c bbox 1] set x2 [lindex $bbox 2] set y2 [lindex $bbox 3] incr y2 update .c find enclosed 99 99 [expr $x2 + 1] [expr $y2 + 1] ---- Result was: ---- Result should have been (exact matching): 1 ==== canvText-18.1 FAILED ==== canvText-20.1 angled text bounding box FAILED ==== Contents of test case: .c create text 2 2 -tag t -anchor center -text 0 -font {Helvetica 24} set bb0 [.c bbox t] .c itemconf t -angle 90 set bb1 [.c bbox t] .c itemconf t -angle 180 set bb2 [.c bbox t] .c itemconf t -angle 270 set bb3 [.c bbox t] list [expr {$bb0 eq $bb2 ? "ok" : "$bb0,$bb2"}] [expr {$bb1 eq $bb3 ? "ok" : "$bb1,$bb3"}] [expr {$bb0 eq [transpose $bb1] ? "ok" : "$bb0,$bb1"}] ---- Result was: {-7 -22 12 27,-8 -23 11 26} {-22 -8 27 11,-23 -7 26 12} {-7 -22 12 27,-22 -8 27 11} ---- Result should have been (exact matching): ok ok ok ==== canvText-20.1 FAILED ---------------------------------------------------------------------- >Comment By: Alexandre Ferrieux (ferrieux) Date: 2009-07-14 22:49 Message: Oh gosh this slipped completely out of my cache :-} Allow for a short pagein delay... ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2009-07-13 14:50 Message: I don't thoroughly understand what your proposed solution is (sorry!) so I'm going to let you have a go at it... ---------------------------------------------------------------------- Comment By: Alexandre Ferrieux (ferrieux) Date: 2008-11-24 00:58 Message: Hmm, ->x2 should be 1 not -1 for the trick to work. Anyway, the alternative remains. ---------------------------------------------------------------------- Comment By: Alexandre Ferrieux (ferrieux) Date: 2008-11-24 00:54 Message: First one is an off-by-one error on test "left>=x2" at line 2915 of tkFont.c for the special layout chunk of size zero: if ((right < x1) || (left >= x2) Here left==0 *and* x2 too (by construction of such chunks). Maybe zeroChunkPtr->x2 should be -1. Alternatively, maybe checks on X axis should be skipped for those chunks (ie when numDisplayChars==-1). Donal ? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=2328657&group_id=12997 |