Menu
▾
▴
[Tcl-bugs] [ tcl-Patches-1960628 ] TEA adjustments/fixes
|
From: SourceForge.net <no...@so...> - 2009-03-12 06:46:59
|
Patches item #1960628, was opened at 2008-05-08 17:06 Message generated for change (Comment added) made by jenglish You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1960628&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 70. Sample Extension Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Stuart Cassoff (stwo) Assigned to: Joe English (jenglish) Summary: TEA adjustments/fixes Initial Comment: If the VPATH needs to deviate from the standard four dirs (src, src/generic,src/unix,wrc/win) an extension writer would need to alter the tcl.m4 file as well as Makefile.in as opposed to need to simply alter configure.in. The new macro, TEA_ADD_VPATH_DIR is used to add directories to the VPATH. TEA_ADD_VPATH_DIR should be called before TEA_ADD_SOURCES or TEA_ADD_STUB_SOURCES to ensure that all source files are found. The default search dirs are now only the src snd src/generic dirs. If needed, src/unix and src/win have to be added manually using TCL_ADD_VPATH_DIR. Also in this patch is a small adjustment to pkgIndex.tcl.in which removes the need to edit pkgIndex.tcl.in for basic usage cases. Also updates TEA_VERSION to 3.7. ---------------------------------------------------------------------- >Comment By: Joe English (jenglish) Date: 2009-03-11 23:46 Message: (For future reference): On the chat, stu pointed (again) to: http://www.openbsd.org/porting/libraries.html ... which if I understand correctly is talking about more or less the standard ELF rules for dynamically-linked libraries and SONAMES. So there doesn't seem to be anything hugely different between the *BSDs and other modern Unices. However -- and this is the part that seems to be widely misunderstood -- the "libfoo.so.major.minor" SONAME naming scheme is only relevant for shared libraries that are dynamically *linked*. For shared libraries that are dynamically *loaded* -- like Tcl extensions! -- the SONAME, and the filename, are utterly irrelevant as far as dlopen() is concerned. (And as far as the Tcl [load] command is concerned, the only part of the filename that matters is the bit between the optional leading "lib" and the first nonalphaorunderline character. See Tcl_LoadObjCmd()). AFAICT, all the autogoo trying to guess the "right" ${SHARED_LIB_SUFFIX} is a PWOT, a WOMBAT, a tapdancing badger. On every Unix I've seen in the last 10 years, you could name the shared library "FOO.DLL" and in Tcl say [package ifneeded foo X.Y [list load [file join $dir FOO.DLL]]] and everything would work Just Fine. What am I missing? ---------------------------------------------------------------------- Comment By: Joe English (jenglish) Date: 2009-03-11 20:25 Message: (For future reference): Stu explained on the chat that ${SHLIB_VERSION} was added so that porters could override the hardcoded ".1.0" part of "libfooXY.so.1.0" at configure-time. (Stu -- if you could further elaborate *why* one might want/need to do so, it would be appreciated. Why not f'rinstance just name the shared library "libfooXY.so" -- or better yet, just "foo.so"? That works just fine on every other ELF-based Unix, why is BSD different here?) ---------------------------------------------------------------------- Comment By: Joe English (jenglish) Date: 2009-03-11 18:01 Message: patch-pkgIndex_tcl and (most of) patch-tclconfig_tcl_m4 committed. ---------------------------------------------------------------------- Comment By: Stuart Cassoff (stwo) Date: 2009-03-09 23:18 Message: Slightly improved versions of previous patches. Older patches left for reference/ideas for possible future changes. File Added: patch-tclconfig_tcl_m4 ---------------------------------------------------------------------- Comment By: Stuart Cassoff (stwo) Date: 2009-03-09 23:18 Message: Slightly improved versions of previous patches. Older patches left for reference/ideas for possible future changes. File Added: patch-pkgIndex_tcl ---------------------------------------------------------------------- Comment By: Kevin B KENNY (kennykb) Date: 2009-01-25 19:06 Message: Ahh. The patch has evolved over time, but I'll still give it a review. ---------------------------------------------------------------------- Comment By: Kevin B KENNY (kennykb) Date: 2009-01-25 19:05 Message: The idea of allowing the VPATH to be extended with whatever the extension needs appears to make eminent sense. I'll have a look at this patch. ---------------------------------------------------------------------- Comment By: Stuart Cassoff (stwo) Date: 2008-09-03 12:20 Message: Logged In: YES user_id=143350 Originator: YES New, simpler patch. pkgIndex.tcl.in: Replace 'Tclsha1' with '@PACKAGE_NAME@' to free an extension writer from having to modify the file. tcl.m4: Use TK_INCLUDE_SPEC to find tk.h, same way as TCL_INCLUDE_SPEC is used to find tcl.h, fixes bug where TEA can't find Tk headers. As part of this, ensure variable 'list' is empty before filling - I don't think it should contain the list of directories for TCL_PUBLIC_HEADERS when it looks for TK_PUBLIC_HEADERS. Remove -Wno-implicit-int from CFLAGS_WARNING. Add AC var SHLIB_VERSION used like: SHARED_LIB_SUFFIX='${TCL_TRIM_DOTS}.so.${SHLIB_VERSION}' to free porters/builders from having to patch tcl.m4 on systems where the shared library version is important. Assorted code/spelling/typo fixes/uniformity. Does not change ephemeral TEA version number '3.6'. File Added: tea36.patch ---------------------------------------------------------------------- Comment By: Stuart Cassoff (stwo) Date: 2008-05-11 10:57 Message: Logged In: YES user_id=143350 Originator: YES New patch does everything the original did plus the following: Uses TK_INCLUDE_SPEC to find tk.h, same way as TCL_INCLUDE_SPEC is used to find tcl.h Additionally checks for tclConfig.sh in: ${exec_prefix}/lib/tcl[8-9].[0-9] ${exec}/lib/tcl[8-9].[0-9] /usr/local/lib/tcl[8-9].[0-9] Additionally checks for tkConfig.sh in: ${exec_prefix}/lib/tk[8-9].[0-9] ${exec}/lib/tk[8-9].[0-9] /usr/local/lib/tk[8-9].[0-9] Added INSTALL_LIBRARY macro. Suitable for archs where install options for binaries and libraries are different (ex: binaries are stripped, libraries aren't). Currently set to ${INSTALL_PROGRAM} - no functional change. Groundwork for future install improvements. Assorted code/spelling/typo fixes/uniformity. File Added: tea_3.6-3.7.patch ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1960628&group_id=10894 |