Menu
▾
▴
[Tcl-bugs] [ tcl-Bugs-2017583 ] unnecessary numLevels++ in tclParse.c?
|
From: SourceForge.net <no...@so...> - 2008-07-14 20:00:43
|
Bugs item #2017583, was opened at 2008-07-13 20:36 Message generated for change (Comment added) made by dgp You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=2017583&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 45. Parsing and Eval Group: None Status: Open Resolution: Fixed Priority: 9 Private: No Submitted By: miguel sofer (msofer) Assigned to: miguel sofer (msofer) Summary: unnecessary numLevels++ in tclParse.c? Initial Comment: I have committed the attached patch that eliminates an unnecessary (I think!) numLevels++ in TclSubstTokens. Note that there is a call to TclEvalEx, which in turn calls Tcl_EvalObjv, which does the numLevel management. If I'm wrong ... please revert. ---------------------------------------------------------------------- >Comment By: Don Porter (dgp) Date: 2008-07-14 16:00 Message: Logged In: YES user_id=80530 Originator: NO hmmm, they're passing, but only because they've been revised. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2008-07-14 15:42 Message: Logged In: YES user_id=80530 Originator: NO Revision 1.40 of tclParse.c was the first to acquire those numLevel manipulations, allegedly to fix Bug 1115904. Tests parse-19.[1-4] were added to test the fix, so if they're still passing, things should be ok. ---------------------------------------------------------------------- Comment By: miguel sofer (msofer) Date: 2008-07-14 08:21 Message: Logged In: YES user_id=148712 Originator: YES Remark that this is related to "Kill TEOVi" (outdated Patch #1904111). All evals now go through TEOV, which manages the numLevel. Before this change direct callers of TEOVi (bypassing TEOV) had to manage the numLevel. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2008-07-14 02:02 Message: Logged In: YES user_id=80530 Originator: NO need a cvs history check for when the code was added, and what bug, if any, it was fixing at the time. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=2017583&group_id=10894 |