[Tcl-bugs] [ tcl-Bugs-1942222 ] useless call to endgrent()/endpwent()

[SourceForge.net <no...@so...>]

Bugs item #1942222, was opened at 2008-04-14 08:22
Message generated for change (Comment added) made by karllim
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1942222&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Rolland Dudemaine (karllim)
Assigned to: Nobody/Anonymous (nobody)
Summary: useless call to endgrent()/endpwent()

Initial Comment:
in unix/tclUnixFCmd.c, GetGroupAttribute() and GetOwnerAttribute() make calls to non-wrapped POSIX calls endpwent() and endgrent().
These two calls are marked to be avoided by the Open Group http://www.opengroup.org/onlinepubs/009695399/functions/getgrent.html
Moreover, the actual calls are useless since TclpGetPwUid() and TclpGetGrUid() do use the newer grgetpw() and grgetgid().

Solution : remove the calls.

----------------------------------------------------------------------

>Comment By: Rolland Dudemaine (karllim)
Date: 2008-04-14 08:28

Message:
Logged In: YES 
user_id=143750
Originator: YES

File Added: tcl_endgrpwent_20080414.diff

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1942222&group_id=10894