Menu
▾
▴
[Tcl-bugs] [ tcl-Bugs-1577492 ] let [info level] know ensemble rewrites
|
From: SourceForge.net <no...@so...> - 2006-10-15 12:27:02
|
Bugs item #1577492, was opened at 2006-10-15 00:02 Message generated for change (Comment added) made by msofer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1577492&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 17. Commands I-L Group: None Status: Open Resolution: None Priority: 8 Submitted By: miguel sofer (msofer) Assigned to: Donal K. Fellows (dkf) Summary: let [info level] know ensemble rewrites Initial Comment: Attached a patch that, while not touching [info level] itself, makes it aware of rewrites: the (objc,objv) fields in each CallFrame are not rewritten during ensemble calls. If the patch in [Bug 1574835] is accepted, it should be modified accordingly so that [interp alias] benefits from this too. ---------------------------------------------------------------------- >Comment By: miguel sofer (msofer) Date: 2006-10-15 09:26 Message: Logged In: YES user_id=148712 Remark that this patch does not really touch (objc, objv) any more than HEAD. Quite the contrary: it avoids touching it for ensemble calls. The fix for itcl or any other weirdo wanting to store things in there itself is to store them *after* pushing the stack frame. Note also: as the core uses TclPushStackFrame and itcl Tcl_PushCallFrame on frames it allocates itself (bwerk!), it is easy to make this patch only touch (objc, objv) on frames pushed on the stack: itcl should never see it. I think ... except if itcl wants to determine what non-itcl call frames do too? ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2006-10-15 00:24 Message: Logged In: YES user_id=80530 Be careful here. As the attempt to fix 1400572 demonstrated, Itcl is sensitive in mysterious ways to what gets stored in those objc, objv fields. May even be storing things there itself? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1577492&group_id=10894 |