From: SourceForge.net <no...@so...> - 2006-02-09 20:42:55
|
Bugs item #1380662, was opened at 2005-12-14 13:51 Message generated for change (Comment added) made by dgp You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1380662&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 25. Channel System Group: current: 8.4.12 Status: Open Resolution: None Priority: 5 Submitted By: Don Porter (dgp) Assigned to: Andreas Kupries (andreas_kupries) Summary: Tcl_StackChannel doesn't permit NULL interp Initial Comment: Tcl_StackChannel() takes an interp argument as a place to write error messages, but doesn't follow the usual practice of accepting a NULL value. This need for non-NULL interp can cascade up, forcing Tcl_FSOpenFileChannel() to need a non-NULL interp as well. ---------------------------------------------------------------------- >Comment By: Don Porter (dgp) Date: 2006-02-09 15:42 Message: Logged In: YES user_id=80530 Revised patch ready for review. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-12-19 11:13 Message: Logged In: YES user_id=80530 good points from dkf: avoid Tcl_Panic() if possible TclChanCaughtErrorBypass() can't seem to make up its mind whether it can handle NULL interp, it should be made to. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-12-14 15:21 Message: Logged In: YES user_id=80530 attached patch takes care of everything I could find. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-12-14 14:32 Message: Logged In: YES user_id=80530 Tcl_Close() and Tcl_UnstackChannel() have similar issue, but appear trickier to untangle. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-12-14 13:59 Message: Logged In: YES user_id=80530 I believe the attached patch corrects the problem. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1380662&group_id=10894 |