[Tcl-bugs] [ tktoolkit-Patches-1237759 ] Bring Tk library up to 8.4 code standards

[SourceForge.net <no...@so...>]

Patches item #1237759, was opened at 2005-07-13 15:02
Message generated for change (Comment added) made by dgp
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312997&aid=1237759&group_id=12997

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 28. Utility Functions
Group: None
Status: Open
Resolution: Remind
Priority: 5
Submitted By: Jeffrey Hobbs (hobbs)
Assigned to: Donal K. Fellows (dkf)
Summary: Bring Tk library up to 8.4 code standards

Initial Comment:
From Patrick Fradin [patrick.fradin at synelec.fr]:

I made next modifications joined in 2 archives :

    - Always use eq / ne to compare strings instead of
string equal, string match, string compare, == and so
on... I think it's simplify code readability and
maintenance.

    - Replace some simple regsub with string map to
improve exec performance

    - Replace some simple regexp with string match for
the same reasons

    - Use unset -nocomplain to avoid if info exists or
catch

    - Use trace add variable write/unset instead of old
trace variable w/u

    - Use trace remove variable instead of old trace
vdelete

    - Use trace info variable instead of old trace vinfo

    - use [list] to initialize empty list instead of ""
or {} string

    - Avoid code abbreviations to clarify code and
avoid reading errors

        ex: string len -> string length
            $w config  -> $w configure ...

    - Replace some simple eval $cmd commands with
"compiled" if 1 $cmd
(speedier)

    - Use foreach to parse values instead of many
lindex (ex: clrpick.tcl)

    - Replace regexp "dummy" variable with "->" to
improve readability

    - I remarked some catch {destroy $w}. I think it's
useless, isn't it ?



----------------------------------------------------------------------

>Comment By: Don Porter (dgp)
Date: 2005-12-13 11:35

Message:
Logged In: YES 
user_id=80530


corrected patch


----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2005-12-13 11:09

Message:
Logged In: YES 
user_id=80530


Here's the requested patch
update from Patrick Fradin,
based on Tk 8.4.12.

----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2005-07-25 14:13

Message:
Logged In: YES 
user_id=80530


dkf has started working on this.

----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2005-07-19 17:45

Message:
Logged In: YES 
user_id=80530


The re-formatting burden is
far too great, compared with
the alleged improvements.

If the originator can supply
a tamer patch that can be
reviewed with reasonable
effort, OK.  Otherwise, consider
this a "Won't fix".

----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2005-07-19 16:44

Message:
Logged In: YES 
user_id=80530


Here's the same changeset as
a (compressed) patch file.

Differences in indentation style
make this patch a lot bigger
than its substance.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312997&aid=1237759&group_id=12997