[Tcl-bugs] [ tcl-Bugs-1204064 ] Tcl 8.4 release compile error

[SourceForge.net <no...@so...>]

Bugs item #1204064, was opened at 2005-05-17 21:56
Message generated for change (Comment added) made by mistachkin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1204064&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 47. Threading
Group: current: 8.4.9
>Status: Open
Resolution: Fixed
Priority: 7
Submitted By: Joe Mistachkin (mistachkin)
Assigned to: Zoran Vasiljevic (vasiljevic)
Summary: Tcl 8.4 release compile error

Initial Comment:

When compiling in release mode using the threaded
memory allocator, the following code causes a problem:

in tclWinThrd.c, function TclpFinalizeThreadData, near
line #705:

#if defined(USE_THREAD_ALLOC) && !defined(TCL_MEM_DEBUG)
        if (indexPtr == &key) {
            TclpFreeAllocCache(result);
            return;
        }
#endif

There is no variable named "key".  I'm not sure what
the precise intent here is.

..\win\tclWinThrd.c(688) : error C2065: 'key' :
undeclared identifier
..\win\tclWinThrd.c(1046) : warning C4142: benign
redefinition of type


----------------------------------------------------------------------

>Comment By: Joe Mistachkin (mistachkin)
Date: 2005-05-29 19:37

Message:
Logged In: YES 
user_id=113501

Fix confirmed in HEAD.  However, this same error still
exists in core-8-4-branch.

----------------------------------------------------------------------

Comment By: Jeffrey Hobbs (hobbs)
Date: 2005-05-29 18:36

Message:
Logged In: YES 
user_id=72656

Fixed in head - the decl was lower in the file.  Renamed to
tlsKey to be more descriptive.  Go ahead and test (passes
test suite).

----------------------------------------------------------------------

Comment By: Joe Mistachkin (mistachkin)
Date: 2005-05-17 22:00

Message:
Logged In: YES 
user_id=113501


Issue introduced:

version 1.24.2.10, Thu Apr 7 11:29:33 2005 UTC


----------------------------------------------------------------------

Comment By: Joe Mistachkin (mistachkin)
Date: 2005-05-17 21:59

Message:
Logged In: YES 
user_id=113501


Perhaps the author wanted to do this?

#if defined(USE_THREAD_ALLOC) && !defined(TCL_MEM_DEBUG)
        if (indexPtr == &dataKey) {
            TclpFreeAllocCache(result);
            return;
        }
#endif


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1204064&group_id=10894