Menu
▾
▴
[Tcl-bugs] [ tktoolkit-Bugs-1016385 ] [rename console] doomed to fail
|
From: SourceForge.net <no...@so...> - 2005-03-21 09:49:04
|
Bugs item #1016385, was opened at 2004-08-25 23:35 Message generated for change (Comment added) made by dkf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=1016385&group_id=12997 Category: 54. [console] Group: obsolete: 8.4.7 Status: Open Resolution: None Priority: 5 Submitted By: Don Porter (dgp) Assigned to: Donal K. Fellows (dkf) Summary: [rename console] doomed to fail Initial Comment: TkConsolePrint() makes use of Tcl_GetCommandInfo(... "console" ...) to get at data it needs to operate. After [console] is [rename]d, that will no longer work. [console] and its supporting cast should rely on things less transient than command names. ---------------------------------------------------------------------- >Comment By: Donal K. Fellows (dkf) Date: 2005-03-21 09:49 Message: Logged In: YES user_id=79902 The fix applied was to use Tcl_GetAssocData() instead of Tcl_GetCommandInfo() as a way to obtain the structure instance. It still leaks like the old code, but now [rename] can't smash it. Backporting should be easy, but I've not had time to do that yet. :^/ ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-03-20 20:23 Message: Logged In: YES user_id=72656 I disagree that this is a misfeature of Tcl at all. This would purely be pilot error. Allowing the renaming of any command is a power feature, and if you do that callously, without replacing it with a sufficient replacement function, that is coder error. In this case, you can capture what the console is when created, but I would argue that isn't necessarily the desired behavior. For example, what if you want to make an uber-console that takes over that input? What was the 'fix' applied? ---------------------------------------------------------------------- Comment By: Chengye Mao (chengyemao) Date: 2005-03-19 15:30 Message: Logged In: YES user_id=191079 A system Tcl command like this should not be renamed. Allowing to rename any Tcl command is a Tcl system loophole. ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2005-03-19 08:05 Message: Logged In: YES user_id=79902 Fixed in HEAD ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-03-18 18:00 Message: Logged In: YES user_id=80530 had a chance to look at this? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=1016385&group_id=12997 |