[Tcl-bugs] [ tcl-Bugs-1109294 ] Tcl_OpenFileChannel doesn't say that argv must end in NULL

[SourceForge.net <no...@so...>]

Bugs item #1109294, was opened at 2005-01-25 19:50
Message generated for change (Comment added) made by davidw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1109294&group_id=10894

Category: 25. Channel System
Group: None
Status: Open
Resolution: None
Priority: 7
Submitted By: David N. Welton (davidw)
Assigned to: Andreas Kupries (andreas_kupries)
Summary: Tcl_OpenFileChannel doesn't say that argv must end in NULL

Initial Comment:
The comments for 

int
TclCreatePipeline(interp, argc, argv, pidArrayPtr,
inPipePtr,
	outPipePtr, errFilePtr)

say that:

    CONST char **argv;		/* Array of strings describing
commands in
				 * pipeline plus I/O redirection with <,
				 * <<,  >, etc.  Argv[argc] must be NULL. */

But the documentation for Tcl_OpenFileChannel makes no
mention of this!  Either the documentation should be
changed, or the command should dispense with the final
NULL requirement (it has an argc, so why does it need a
final NULL, too?).

----------------------------------------------------------------------

>Comment By: David N. Welton (davidw)
Date: 2005-01-26 00:15

Message:
Logged In: YES 
user_id=240

I whipped up the following patch, which eliminates the
requirement for argv[argc] to exist and be NULL.  It works
for me, and seems to pass the relevant tests.  I've got a
nasty case of the flu, so my addled brain may have missed
something:-)

----------------------------------------------------------------------

Comment By: Andreas Kupries (andreas_kupries)
Date: 2005-01-25 20:02

Message:
Logged In: YES 
user_id=75003

Note: David had a mem corruption issue and crash because of
this. The easy fix, updating the docs, might not be the
right fix.

This needs a deeper look.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1109294&group_id=10894