From: SourceForge.net <no...@so...> - 2005-01-10 18:59:05
|
Patches item #1081595, was opened at 2004-12-08 12:10 Message generated for change (Settings changed) made by jenglish You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1081595&group_id=10894 Category: 51. Configure and Build Tools Group: TIP Implementation >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Joe English (jenglish) >Assigned to: Joe English (jenglish) Summary: Die, DBGX, die Initial Comment: As recommended by TIP #34, the attached patch removes ${TCL_DBGX} and ${DBGX} from Tcl's build system. This no longer serves a useful purpose (if it ever did). Rerun 'autoconf' after applying the patch (diff to 'configure' script not included). ---------------------------------------------------------------------- >Comment By: Joe English (jenglish) Date: 2005-01-10 10:59 Message: Logged In: YES user_id=68433 Committed to tcl and tk CVS HEAD; re-synced tk/unix/tcl.m4 with tcl/unix/tcl.m4. ---------------------------------------------------------------------- Comment By: Joe English (jenglish) Date: 2004-12-29 15:47 Message: Logged In: YES user_id=68433 Committed tea-die-dbgx-die.patch. This only affects the sample extension, and any future TEA extensions that copy tcl.m4 from the sampleextension CVS HEAD. ---------------------------------------------------------------------- Comment By: Joe English (jenglish) Date: 2004-12-09 13:41 Message: Logged In: YES user_id=68433 Re: widening the gap between the Windows and Unix world -- it would be an astonishingly good idea to remove TCL_DBGX from the Windows build system too. I haven't done that simply because I don't have access to a Windows machine that I can test on. ---------------------------------------------------------------------- Comment By: Joe English (jenglish) Date: 2004-12-09 13:37 Message: Logged In: YES user_id=68433 Oops! Sorry, forgot to include that file in the patch. New patch fixes. Additional diffs: 26,28c26,28 < # If TCL was built with debugging symbols, generated libraries contain < # this string at the end of the library name (before the extension). < TCL_DBGX=@TCL_DBGX@ --- > # TCL_DBGX used to be used to distinguish debug vs. non-debug builds. > # This was a righteous pain so the core doesn't do that any more. > TCL_DBGX= ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2004-12-09 08:45 Message: Logged In: YES user_id=80530 even better, follow what you did for Tk and just hardwire the value to the empty string. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2004-12-09 08:32 Message: Logged In: YES user_id=80530 shouldn't the TCL_DBGX line in unix/tclConfig.sh.in be removed as well? As is, the generated tclConfig.sh file contains: TCL_DBGX=@TCL_DBGX@ and I doubt any other code can make sense of that. Wouldn't a missing value be better than a nonsense one? ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2004-12-08 14:31 Message: Logged In: YES user_id=79902 Hmm, I'm not at all sure about the impact on the widening of the gap between the unix and win worlds that this would have. ---------------------------------------------------------------------- Comment By: Joe English (jenglish) Date: 2004-12-08 12:46 Message: Logged In: YES user_id=68433 ... and the same thing for the sample extension. TEA still needs to account for the possibility that ${TCL_DBGX} is referenced in tclConfig.sh, but there's no reason for extensions to add a ${DBGX} suffix to their own shared libraries. ---------------------------------------------------------------------- Comment By: Joe English (jenglish) Date: 2004-12-08 12:23 Message: Logged In: YES user_id=68433 ... and the same for Tk. It looks like Tk's copy of tcl.m4 has gotten out of sync with Tcl's; the tk patch also resyncs them. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1081595&group_id=10894 |