[Tcl-bugs] [ tcl-Bugs-1030548 ] Tcl 8.4 fails to build in debug/threaded config

[SourceForge.net <no...@so...>]

Bugs item #1030548, was opened at 2004-09-18 20:30
Message generated for change (Comment added) made by hobbs
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1030548&group_id=10894

Category: 40. Memory Allocation
Group: current: 8.4.8
>Status: Pending
Resolution: Fixed
>Priority: 8
Submitted By: Joe Mistachkin (mistachkin)
>Assigned to: Jeffrey Hobbs (hobbs)
Summary: Tcl 8.4 fails to build in debug/threaded config

Initial Comment:

tclThreadAlloc.c
..\generic\tclThreadAlloc.c(974) : error C2220: warning
treated as error - no object file generated
..\generic\tclThreadAlloc.c(974) : warning C4013:
'TclpFreeAllocMutex' undefined; assuming extern
returning int
NMAKE : fatal error U1077: 'cl' : return code '0x2'
Stop.

The problem has to do with the re-organization of the
threaded memory allocator related defines a while back.

When compiling with debugging, the TclpFreeAllocMutex
does not get declared in tclInt.h (and some other
functions as well).


----------------------------------------------------------------------

>Comment By: Jeffrey Hobbs (hobbs)
Date: 2004-12-02 12:03

Message:
Logged In: YES 
user_id=72656

I believe this issue is correctly fixed, and the Dossy's
configuration was never a valid product of the Tcl
'configure' script.

----------------------------------------------------------------------

Comment By: Donal K. Fellows (dkf)
Date: 2004-12-01 14:22

Message:
Logged In: YES 
user_id=79902

What is the aspect of aolserver that fails to build when
threads+TCL_MEM_DEBUG are enabled? I can *almost* but not
quite grasp what's going on... ;^)

----------------------------------------------------------------------

Comment By: Dossy Shiobara (dossy)
Date: 2004-11-23 13:38

Message:
Logged In: YES 
user_id=21885

This "fix" that went into 8.4.8 breaks a portion of our
Tcl/AOLserver  build at AOL.

I think this change needs to be backed out, and the build
for Win32  needs to be corrected.

At AOL, we have four different builds: (1) a threaded build
with the zippy allocator; (2) a threaded build without the
zippy allocator; (3) a threaded build with the zippy
allocator and TCL_MEM_DEBUG on; and (4) a threaded build
without the zippy allocator but with TCL_MEM_DEBUG on.

We build these four configurations on Linux and Solaris but
not Win32.

I suspect that the change in ifdef's has probably broken our
builds in other configurations, but configs #3 and #4 above
completely fail to build now.  (Tcl builds, but AOLserver
doesn't.)

Can we revisit this change and discuss backing out the
change and correcting the Win32 build so that it's in line
with the other platform builds?


----------------------------------------------------------------------

Comment By: Andreas Kupries (andreas_kupries)
Date: 2004-10-28 14:14

Message:
Logged In: YES 
user_id=75003

Got ok by Don. Committed to 8.4 head.


----------------------------------------------------------------------

Comment By: Andreas Kupries (andreas_kupries)
Date: 2004-10-26 12:34

Message:
Logged In: YES 
user_id=75003

Kevin created a patch for this, and I fixed the patch. Here
is the combined diff.



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1030548&group_id=10894