[Tcl-bugs] [ tcl-Bugs-935160 ] OSX warnings and errors (6)

[SourceForge.net <no...@so...>]

Bugs item #935160, was opened at 2004-04-14 14:52
Message generated for change (Comment added) made by tauvan
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=935160&group_id=10894

Category: 51. Configure and Build Tools
Group: current: 8.4.6
Status: Open
Resolution: None
Priority: 5
Submitted By: tauvan (tauvan)
Assigned to: Mo DeJong (mdejong)
Summary: OSX warnings and errors (6)

Initial Comment:
machine: mac ppc G4 (1st PCI 400Mhz) OSX 10.1.5

My (6) suggestion is:
  change:
    tclInt.decls, tclUnixPort.h, tclUnixThrd.c, tclIntPlatDecls.h
  to "CONST time_t *" from "time_t *"

Solves:
  warning: passing arg 1 of `TclpGmtime' discards qualifiers 
from pointer target type
  warning: passing arg 1 of `TclpLocaltime' discards qualifiers 
from pointer target type

Condition:
    "OSX warnings and errors (1)" not required
    "OSX warnings and errors (2)" performed
    quick fix performed

Suggestion:
   All "TclpLocaltime(time_t *" to "TclpLocaltime(CONST time_t *"
   All "TclpGmtime(time_t *" to "TclpGmtime(CONST time_t *"
   struct tm * (*tclpLocaltime) _ANSI_ARGS_((CONST time_t * 
clock));
   struct tm * (*tclpGmtime) _ANSI_ARGS_((CONST time_t * 
clock));
   tools/genStubs.tcl should take care of tclIntPlatDecls.h

Special Notes:
    OSX prototype for gmtime & localtime use "const time_t *"
    glibc uses "__const time_t *"
    Linux Programmer's Manual uses "const time_t *"

Results from (6):
  trashed previous builds
  make -C ./tcl8.4.6/macosx develop
  ./build/tcl/tcltest ./tcl8.4.6/tests/all.tcl
  less warnings
  w & w/o (1) same

Thanks.


----------------------------------------------------------------------

>Comment By: tauvan (tauvan)
Date: 2004-05-16 12:55

Message:
Logged In: YES 
user_id=1011552

  This report can be closed as it
seems to be incorporated as of 2004-05-14.
see changes in change log
2004-05-14  Kevin B. Kenny.
It doesn't mention this bug, but it now rejects
the attached patch and the keyword "CONST" seems
to be applied.
  Thanks

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=935160&group_id=10894