[Tcl-bugs] [ tcl-Bugs-928506 ] BUILD_tcl

[SourceForge.net <no...@so...>]

Bugs item #928506, was opened at 2004-04-02 15:10
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=928506&group_id=10894

Category: 46. Bytecode Compiler
Group: current: 8.4.6
Status: Open
Resolution: None
Priority: 5
Submitted By: tauvan (tauvan)
Assigned to: miguel sofer (msofer)
Summary: BUILD_tcl

Initial Comment:
Me agian.

#-------------------------------
tclCompile.h:

Original Code:
#ifndef _TCLINT
#include "tclInt.h"
#endif /* _TCLINT */

#ifdef BUILD_tcl
# undef TCL_STORAGE_CLASS
# define TCL_STORAGE_CLASS DLLEXPORT
#endif

Proposed:
#include "tclInt.h"

see "tracking defines"

#-------------------------------
tclRegexp.h:
Removed:
#ifdef BUILD_tcl
# undef TCL_STORAGE_CLASS
# define TCL_STORAGE_CLASS DLLEXPORT
#endif

#-------------------------------
tclInt.h:

Original Code:
#define _TCLINT ....... to
/*
 * The following procedures allow namespaces to be customized 
to
changed to:
#define _TCLINT

#include "tcl.h"
/*
 * Common include files needed by most of the Tcl source files 
are
 * included here, so that system-dependent personalizations for 
the
 * include files only have to be made in once place.  This results
 * in a few extra includes, but greater modularity.  The order of
 * the three groups of #includes is important.	For example, 
stdio.h
 * is needed by tcl.h, and the _ANSI_ARGS_ declaration in tcl.h 
is
 * needed by stdlib.h in some configurations.
 */

#include <ctype.h>
#include <limits.h>
#include <stdlib.h>
#include <string.h>

#undef TCL_STORAGE_CLASS

#ifdef USE_TCL_STUBS
#   define TCL_STORAGE_CLASS
#else
#   define TCL_STORAGE_CLASS DLLIMPORT
#endif

/*
 * The following procedures allow namespaces to be customized 
to

Logic:
the above header and attached "tcl.h"

#-------------------------------
tcl.h:

the top part consolidates almost all "compat" issues in one
location.

I had a problem of <limits.h> seeing "limits.h" in compat instead 
of
system&#039;s <limits.h> ... and with others
define <????> to ??????
might need 
#ifndef
#define SOME_HEADER ?????


According to Makefile.in
# On unix we want to use the normal malloc/free 
implementation, so we
# specifically set the USE_TCLALLOC flag.
-DUSE_TCLALLOC=0

only #ifdef MAC_TCL sets USE_TCLALLOC

so added #else sets -DUSE_TCLALLOC=0 and makes
Makefile.in condition for all files not just tclAlloc.c
since once you start compile it&#039;s not defined anyway
except when MAC_TCL is requested

call this "insurance" I guess.

removed: (made standard include for all files @ top)
#ifndef BUFSIZ
#   include <stdio.h>
#endif

the "#if !defined(NO_STDARG)" section:
this code should be in the actual <stdarg.h>
but was used to stop complier warnings

the "#ifdef BUILD_tcl"
again removed (previous sumitted "fixes")
not ever defined

ifdef NO_LIMITS_H changed to ifndef HAVE_LIMITS_H
HAVE_LIMITS_H gets defined twice during makefile process

the "#include <defines.h>" should be removed. It&#039;s a file created 
from
configure&#039;s "confdef.h" file


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=928506&group_id=10894