Menu
▾
▴
[Tcl-bugs] [ tktoolkit-Patches-621901 ] objectify text widget
|
From: SourceForge.net <no...@so...> - 2003-01-20 10:58:39
|
Patches item #621901, was opened at 2002-10-11 14:32 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312997&aid=621901&group_id=12997 Category: 18. [text] Group: None Status: Open Resolution: None Priority: 6 Submitted By: Vince Darley (vincentdarley) Assigned to: Jeffrey Hobbs (hobbs) Summary: objectify text widget Initial Comment: Attached is a patch to objectify the text widget. It should be complete, except there seems to be some sort of init bug which causes a crash on startup, at least on Windows, which I don't understand. This may be caused by some errors in the new option table, but I'm not sure... I'd appreciate it if someone who understands this better could take a look at this some more... ---------------------------------------------------------------------- >Comment By: Vince Darley (vincentdarley) Date: 2003-01-20 11:02 Message: Logged In: YES user_id=32170 Updated the patch to reflect the fact that the Tcl stringObj bug has been fixed. This makes multi-line searching a little more efficient now. Awaiting vote on this TIP. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-11-21 17:56 Message: Logged In: YES user_id=32170 Fixed one small bug, and improved performance slightly in searching. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-11-12 21:53 Message: Logged In: YES user_id=32170 Completed documentation and tests. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-11-12 16:48 Message: Logged In: YES user_id=32170 More debugging while testing this with Alphatk, etc. Fixed a variety of small issues and cleaned up code. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-11-11 22:13 Message: Logged In: YES user_id=32170 Added to test suite, man page, and fixed a couple of problems. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-11-11 16:21 Message: Logged In: YES user_id=32170 Had to gzip patch to meet SF's attachment size constraints. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-11-11 16:19 Message: Logged In: YES user_id=32170 Attached patch which objectifies still further, cleans up the TextSearchCmd function and adds an implementation of tip113. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2002-10-29 17:07 Message: Logged In: YES user_id=80530 Not a branch just for this. Branch off stable 8.4 development, and place this on the HEAD as the first of many patches that will need testing before going out in a "stable" release. Yes, I think we need to do this. We already released 8.4.1 with new bugs we introduced since 8.4.0 because we accepted patches for a "stable" release without adequate testing. We need to restore the HEAD to be a place we can test code, and keep the 8.4 release branch as a separate place. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-10-29 17:04 Message: Logged In: YES user_id=32170 Given this is an entirely internal patch (no feature changes) and relatively minor I'm not sure it really needs a new branch itself, but in any case we should create a new branch and encourage discussion/voting/development on the numerous outstanding TIPs, should we not? ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2002-10-29 16:05 Message: Logged In: YES user_id=80530 committed for 8.5a development you mean? Time to branch, eh? ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-10-29 13:35 Message: Logged In: YES user_id=32170 Attaching newer version; some further objectification, and extensive testing over last few weeks. Given 8.4.1 has now been released, this could be committed to cvs now, if the maintainers agree. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-10-16 12:29 Message: Logged In: YES user_id=32170 Added new Tcl_Obj type for caching of text indices. Still needs further work, but still passes all tests and out to be faster. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-10-15 13:31 Message: Logged In: YES user_id=32170 Yet another patch! More objectification, primarily around the undo/redo code, which should make it much more efficient if large undos are required (no copying of megabyte strings, for example). Required changes to the private interfaces defined in tkUndo.h. It also fixes some potential bugs in the undo code, if a text widget has been renamed either to something inside a namespace or to something which 'eval' will break apart. It would be good to put this in after 8.4.1 is released. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-10-15 11:47 Message: Logged In: YES user_id=32170 Objectified some code a level deeper. Made more use of modern Tcl'isms like 'Tcl_WrongNumArgs', 'Tcl_GetIndexFromObj', etc. Ensures all error msgs are standardised. ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2002-10-14 18:20 Message: Logged In: YES user_id=72656 This would go in post-8.4.1 to get more testing time. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-10-14 17:05 Message: Logged In: YES user_id=32170 Cleaned up some of the code, and re-gen'd the patch. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-10-14 13:21 Message: Logged In: YES user_id=32170 Final patch. Resolves '-wrap' and '-selectborderwidth' issues. Passes all tests that tk8.4.0 passes on Windows. Please test on unix/mac. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-10-14 12:21 Message: Logged In: YES user_id=32170 New patch, cleans up widget cmd to use newer objectified procs. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-10-14 10:56 Message: Logged In: YES user_id=32170 The attached patch now works and passes all important tests in the test suite. The only remaining issues to deal with are understanding/defining appropriate semantics of '-wrap {}' and '-(select)?borderwidth {}' on the text widget and/or on tags. (And these semantics need not agree 100% with tk8.4.0, since there may be bugs in that, for example, 'text .t -wrap {}' doesn't throw an error, but should). On Windows, I also see a variety of errors in textWind.text, but these have been know for some time (Tk bug# 582371). ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-10-11 17:04 Message: Logged In: YES user_id=32170 The attached patch passes most of the test suite, but seems to have a strange crash in it somewhere. Would be good to test this on unix... ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2002-10-11 15:57 Message: Logged In: YES user_id=32170 Attaching newer patch. Still a crash in while freeing colors and borders... ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312997&aid=621901&group_id=12997 |