[Tcl-bugs] [ tcl-Patches-474358 ] a patch for iso2022-jp probrems

[<no...@so...>]

Patches item #474358, was opened at 2001-10-23 23:04
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=310894&aid=474358&group_id=10894

Category: 42. UTF-8 Strings
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Taguchi, Takeshi. (taguchiv6)
Assigned to: Jan Nijtmans (nijtmans)
Summary: a patch for iso2022-jp probrems

Initial Comment:
Here is a patch for iso2022-jp related
probrems(BUG iD#218099,219283,219314).

Sorry, I can't say this patch is good
enough.
But some test scripts are seem work.

Thanks.
---
Taguchi, Takeshi.

----------------------------------------------------------------------

>Comment By: Andreas Kupries (andreas_kupries)
Date: 2002-01-21 13:58

Message:
Logged In: YES 
user_id=75003

I applied this patch to the current state of 8.3.4 and 
8.4cvs head. In both cases there are three encoding-related 
tests which will fail when the testsuite is run. See below. 

I am not well versed enough in this area to know if the 
change should make the tests fail (and thus the tests have 
to be updated) or if the failure points to a bug in the 
patch itself.

Because of this I believe that the patch as it is now is 
not applicable. If the tests have to be changed the patch 
should contain the updates to the testsuite.

==== encoding-11.5 LoadEncodingFile: escape file FAILED
==== Contents of test case:

    encoding convertto iso2022 \u4e4e

---- Result was:
ESC$@8CESC(B
---- Result should have been:
ESC(BESC$@8C
==== encoding-11.5 FAILED


==== encoding-13.1 LoadEscapeTable FAILED
==== Contents of test case:

    set x [encoding convertto iso2022 ab\u4e4e\u68d9g]

---- Result was:
abESC$@8CESC$(DD%ESC(Bg
---- Result should have been:
ESC(BabESC$@8CESC$(DD%ESC(Bg
==== encoding-13.1 FAILED

==== io-1.8 Tcl_WriteChars: WriteChars FAILED
==== Contents of test case:

    # This test written for SF bug #506297.
    #
    # Executing this test without the fix for the 
referenced bug
    # applied to tcl will cause tcl, more specifically 
WriteChars, to
    # go into an infinite loop.

    set f [open test2 w]
    fconfigure      $f -encoding iso2022-jp
    puts -nonewline $f [format %s%c [string repeat " " 4] 
12399]
    close           $f
    contents test2

---- Result was:
    ESC$@$OESC(B
---- Result should have been:
ESC(B    ESC$@$O
==== io-1.8 FAILED


----------------------------------------------------------------------

Comment By: Taguchi, Takeshi. (taguchiv6)
Date: 2001-10-25 21:39

Message:
Logged In: YES 
user_id=357728

I found a probrem in old patch.
This patch still add not-needed escape sequences to tail of
string.

here is a new patch.
I think this one will resolve many probrems on
escape driven encoding.
 

----------------------------------------------------------------------

Comment By: Taguchi, Takeshi. (taguchiv6)
Date: 2001-10-23 23:10

Message:
Logged In: YES 
user_id=357728

Sorry, I've forgot check box.
---
Taguchi,T.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=310894&aid=474358&group_id=10894