[Tcl-bugs] [ tcl-Bugs-466102 ] test winFCmd-2.5 hangs

[<no...@so...>]

Bugs item #466102, was opened at 2001-09-28 09:11
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=110894&aid=466102&group_id=10894

Category: 35. File System
Group: 8.4a4
Status: Open
Resolution: None
Priority: 3
Submitted By: Kevin B KENNY (kennykb)
>Assigned to: Vince Darley (vincentdarley)
Summary: test winFCmd-2.5 hangs

Initial Comment:
On a system running Windows NT 4.0 SP6, compiling with NODEBUG=0, the
test winFCmd-2.5 hangs the process.

----------------------------------------------------------------------

Comment By: Kevin B KENNY (kennykb)
Date: 2001-10-18 14:56

Message:
Logged In: YES 
user_id=99768

Fine with me on NT. Thanks.

----------------------------------------------------------------------

Comment By: Jeffrey Hobbs (hobbs)
Date: 2001-10-12 13:36

Message:
Logged In: YES 
user_id=72656

This is OK for me on Win2K as well.

----------------------------------------------------------------------

Comment By: Vince Darley (vincentdarley)
Date: 2001-10-05 04:03

Message:
Logged In: YES 
user_id=32170

Just to clarify, this test is testing a 'bad case', trying 
to copy "" somewhere.  The hang most likely is occuring 
when the Win32 CopyFileA/W function is called.

The fix is probably to check first whether the path is both 
non-null and non-empty, just as is currently done 
with 'nativeDst'.  I leave this to Kenny to test, since I 
don't have a suitable machine.

Add something like:

if (nativeSrc == NULL || (*nativeSrc == '\0')) {
   Tcl_SetErrno
   return TCL_ERROR;
}


----------------------------------------------------------------------

Comment By: Vince Darley (vincentdarley)
Date: 2001-09-28 16:17

Message:
Logged In: YES 
user_id=32170

I can't reproduce this on my machine, but I'm not running 
NT.  However, the following in tclWinFCmd.c (DoCopyFile):

    /* 
     * If 'nativeDst' is NULL, the following code can lock 
the process
     * up, at least under Windows2000.  Therefore we have 
to bail at
     * that point.
     */
    if (nativeDst == NULL) {
	Tcl_SetErrno(ENOENT);
        return TCL_ERROR;
    }

would seem to be relevant.  It seems as if perhaps 
something similar applies on your platform if 'nativeSrc' 
is NULL or empty or something (since that's what the test 
which hangs is doing).



----------------------------------------------------------------------

Comment By: Kevin B KENNY (kennykb)
Date: 2001-09-28 09:24

Message:
Logged In: YES 
user_id=99768

Oops.  Sorry.  Latest HEAD.

I think the underlying problem is with CopyFileA in kernel32.dll, but we
probably need to check for the case.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2001-09-28 09:20

Message:
Logged In: NO 

Is this with the latest cvs head or tcl 8.3.3 or...?

thanks -- Vince.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=110894&aid=466102&group_id=10894