[Tcl-bugs] [ tcl-Bugs-468098 ] Tk_GetBitmapFromData broken

[<no...@so...>]

Bugs item #468098, was opened at 2001-10-04 15:32
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=110894&aid=468098&group_id=10894

Category: None
Group: 8.3.3
Status: Closed
Resolution: Invalid
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Don Porter (dgp)
Summary: Tk_GetBitmapFromData broken

Initial Comment:
The now obsolete function Tk_GetBitmapFromData, if
used, will corrupt the bitmap hashtable causing much
grief later on...  This problem appears to be present
in 8.4 as well.

To put your mind at ease, after fixing this bug in Tk,
I then went into my code and removed 
Tk_GetBitmapFromData, replacing it with
Tk_DefineBitmap.  If you don't fix the bug, then remove
the function altogether.

Thanks,
-Brian


The following fixes the problem:

$ cvs diff -p tkBitmap.c
Index: tkBitmap.c
===================================================================
RCS file: /cvsroot/tktoolkit/tk/generic/tkBitmap.c,v
retrieving revision 1.7.12.1
diff -p -r1.7.12.1 tkBitmap.c
*** tkBitmap.c  2001/04/04 07:57:16     1.7.12.1
--- tkBitmap.c  2001/10/04 22:15:41
*************** Tk_GetBitmapFromData(interp, tkwin,
sour
*** 818,825 ****
      char string[16 + TCL_INTEGER_SPACE];
      char *name;
      TkDisplay *dispPtr = ((TkWindow *)
tkwin)->dispPtr;
  
!     BitmapInit(dispPtr);
  
      nameKey.source = source;
      nameKey.width = width;
--- 818,829 ----
      char string[16 + TCL_INTEGER_SPACE];
      char *name;
      TkDisplay *dispPtr = ((TkWindow *)
tkwin)->dispPtr;
+     ThreadSpecificData *tsdPtr = (ThreadSpecificData
*) 
+             Tcl_GetThreadData(&dataKey,
sizeof(ThreadSpecificData));
  
!     if (!tsdPtr->initialized) {
!       BitmapInit(dispPtr);
!     }
  
      nameKey.source = source;
      nameKey.width = width;


----------------------------------------------------------------------

Comment By: Brian Griffin (bgriffin)
Date: 2001-10-10 16:55

Message:
Logged In: YES 
user_id=22949

So, should I reenter this report under tktoolkit project?

By the way, this fix did not completely resolve the problem,
but I didn't determine why.

-Brian


----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2001-10-05 21:24

Message:
Logged In: YES 
user_id=80530

This report concerns the interface of the Tk extension.
It should be registered with the tktoolkit project,
not the tcl project.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=110894&aid=468098&group_id=10894