Re: [MACTCL] recent tcl cvs problem?

[Daniel A. S. <st...@ic...>]

James,

On 17/06/2004, at 20:16, Daniel A. Steffen wrote:
> On Wednesday, Jun 16, 2004, at 04:47 Australia/Sydney, James Tittle II 
> wrote:
>
>> ...just as an update, I've now done a new cvs pull from the head, and 
>> still can't compile it!?!  Getting the same errors as previously 
>> mentioned (conflicting "previously defined" errors, mostly with 
>> tcl/compat/string.h):  has anyone successfully compiled tcl.framework 
>> on 10.3.4 with xcode 1.2?
>
> yes... I compile the HEAD as well as core-8-4-branch at least one a 
> week, I've seen no problems similar to yours;

apologies, I was wrong, configure was indeed broken; a local 
modification to configure.in and the presence of an autom4te.cache had 
conspired to hide this from me...

the issue turns out to be due to a missing update to autconf-2.5 syntax 
in the Darwin section of tcl.m4 that was only exposed in Jeff's recent 
move of CFLAGS use to much earlier in the configure process (we were 
manually adding quoted defines to CFLAGS instead of using the 
appropriate autoconf macros, c.f. patch below).

I've checked in these fixes to tcl&tk, so the HEAD builds again on 
Darwin.

sorry for the confusion

Cheers,

Daniel

-- 
** Daniel A. Steffen     **  "And now for something completely
** Dept. of Mathematics  **   different"    Monty Python
** Macquarie University  **  <mailto:st...@ma...>
** NSW 2109 Australia    **  <http://www.maths.mq.edu.au/~steffen/>


Index: unix/tcl.m4
===================================================================
RCS file: /cvsroot/tcl/tcl/unix/tcl.m4,v
retrieving revision 1.115
diff -u -p -r1.115 tcl.m4
--- unix/tcl.m4	26 May 2004 22:51:58 -0000	1.115
+++ unix/tcl.m4	18 Jun 2004 15:12:23 -0000
@@ -1318,9 +1318,10 @@ dnl AC_CHECK_TOOL(AR, ar)
  	    LD_SEARCH_FLAGS=""
  	    CFLAGS_OPTIMIZE="-Os"
  	    LD_LIBRARY_PATH_VAR="DYLD_LIBRARY_PATH"
-	    # for compatibility with autoconf vers 2.13 :
-	    HACK=""
-	    CFLAGS="$CFLAGS -DMA${HACK}C_OSX_TCL -DHAVE_CFBUNDLE -DUSE_VFORK 
-DTCL_DEFAULT_ENCODING=\\\"utf-8\\\""
+	    AC_DEFINE(MAC_OSX_TCL)
+	    AC_DEFINE(HAVE_CFBUNDLE)
+	    AC_DEFINE(USE_VFORK)
+	    AC_DEFINE_UNQUOTED(TCL_DEFAULT_ENCODING,"utf-8")
  	    LIBS="$LIBS -framework CoreFoundation"
  	    ;;
  	NEXTSTEP-*)