From: SourceForge.net <no...@so...> - 2007-01-31 03:20:10
|
Feature Requests item #1632599, was opened at 2007-01-10 10:05 Message generated for change (Comment added) made by sf-robot You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=351645&aid=1632599&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Priority: 5 Private: No Submitted By: Markus Elfring (elfring) Assigned to: David M. Beazley (beazley) Summary: Improve const-correctness Initial Comment: Would you like to apply the advices from the article "http://en.wikipedia.org/wiki/Const-correctness" to more places in your sources? I suggest to add the key word "const" to the type specifiers for parameters like the following. - http://swig.svn.sourceforge.net/viewvc/swig/trunk/Source/CParse/parser.y?revision=9632&view=markup n (function "copy_node") name (functions "is_operator", "make_class_name") - http://swig.svn.sourceforge.net/viewvc/swig/trunk/Source/DOH/base.c?revision=9629&view=markup buffer (function "DohWrite") - http://swig.svn.sourceforge.net/viewvc/swig/trunk/Source/DOH/file.c?revision=9607&view=markup filename (function "DohFileErrorDisplay") - http://swig.svn.sourceforge.net/viewvc/swig/trunk/Source/DOH/string.c?revision=9631&view=markup so (function "CopyString") - all global variables: cvsroot_ ... How do you think about to make them also static (useable only in their own compilation unit)? ---------------------------------------------------------------------- >Comment By: SourceForge Robot (sf-robot) Date: 2007-01-30 19:20 Message: Logged In: YES user_id=1312539 Originator: NO This Tracker item was closed automatically by the system. It was previously set to a Pending status, and the original submitter did not respond within 14 days (the time period specified by the administrator of this Tracker). ---------------------------------------------------------------------- Comment By: Olly Betts (olly) Date: 2007-01-16 06:12 Message: Logged In: YES user_id=14972 Originator: NO It's hard to understand exactly what you're suggesting without a patch to read, but appropriate use of const is a Good Thing in my book so I would support changes in that direction. Beware that it can be hard to retrofit const in a piecemeal way though - if a function is changed to take a const pointer, all the functions it passes the pointer to need to be changed first (or at the same time), or else you need to cast away the const, which really is best avoided. So starting with the lowest level functions is probably best. Dave is actually currently working on cleaning up SWIG's internal APIs, so I'll assign this item to him as his opinion is probably more relevant. I'm not sure about the cvsroot_ variables being made static - they aren't used (except to allow finding out exactly which versions of files were used to build a particular binary by running "strings" on it) so I think they may be deliberately non-static to avoid warnings that they are unused from some compilers. ---------------------------------------------------------------------- Comment By: Markus Elfring (elfring) Date: 2007-01-16 05:45 Message: Logged In: YES user_id=572001 Originator: YES I would like to be sure that my suggestion fits to the intended API design. How do you think about it? ---------------------------------------------------------------------- Comment By: Olly Betts (olly) Date: 2007-01-14 04:31 Message: Logged In: YES user_id=14972 Originator: NO If you want to propose changes to the source code, please supply patches rather than attempting to describe the changes in English. This makes it much easier for use to understand and apply your changes. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=351645&aid=1632599&group_id=1645 |