[Swig-cvs] [swig/swig] 07e256: Remove long line wrapping from Python parameter li...

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/swig/swig
  Commit: 07e2568a2087f095020f6ffed6fe92d4f6ee8162
      https://github.com/swig/swig/commit/07e2568a2087f095020f6ffed6fe92d4f6ee8162
  Author: Vadim Zeitlin <vz...@ze...>
  Date:   2014-08-10 (Sun, 10 Aug 2014)

  Changed paths:
    M Source/Modules/python.cxx

  Log Message:
  -----------
  Remove long line wrapping from Python parameter list generation code.

This doesn't play well with PEP8 checks which imposes very strict continuation
line indentation rules which need to be _visually_ aligned, i.e. the subsequent
lines must be indented by the position of the opening bracket in the function
declaration line, but the code generating the parameter lists doesn't have
this information and so it's impossible to do it while avoiding either E128 or
E123 ("continuation line {under,over}-indented for visual indent" respectively)
error from pep8.

Moreover, the wrapping code didn't work correctly anyhow as it only took into
account the length of the parameter list itself and not the total line length,
which should include the function name as well.

So just disable wrapping entirely, long lines shouldn't be a problem anyhow in
auto-generated code.


  Commit: 9f1af8921fe716923b6a8ca63a1116f2256cf849
      https://github.com/swig/swig/commit/9f1af8921fe716923b6a8ca63a1116f2256cf849
  Author: Vadim Zeitlin <vz...@ze...>
  Date:   2014-08-16 (Sat, 16 Aug 2014)

  Changed paths:
    M Source/Modules/csharp.cxx
    M Source/Modules/d.cxx
    M Source/Modules/java.cxx
    M Source/Modules/lang.cxx
    M Source/Modules/modula3.cxx
    M Source/Modules/swigmod.h

  Log Message:
  -----------
  Refactor: move makeParameterName() to common Language base class.

This method was duplicated more or less identically for 4 languages and will
be needed for another one soon, so put it in the base class from which it can
be simply reused instead.

No changes in the program behaviour whatsoever.


  Commit: 80a72d50c7b18a8bb0762e65d18e3b54a7e5e553
      https://github.com/swig/swig/commit/80a72d50c7b18a8bb0762e65d18e3b54a7e5e553
  Author: Vadim Zeitlin <vz...@ze...>
  Date:   2014-08-16 (Sat, 16 Aug 2014)

  Changed paths:
    M Source/Modules/python.cxx

  Log Message:
  -----------
  No real changes, just make PYTHON::check_kwargs() const.

This will allow calling it from const methods too.


  Commit: fdc6bbeda387fb49ab7dcdbb0f17e4645db3115c
      https://github.com/swig/swig/commit/fdc6bbeda387fb49ab7dcdbb0f17e4645db3115c
  Author: Vadim Zeitlin <vz...@ze...>
  Date:   2014-08-17 (Sun, 17 Aug 2014)

  Changed paths:
    M Source/Modules/python.cxx

  Log Message:
  -----------
  Don't always use "*args" for all Python wrapper functions.

Due to what seems like a bug introduced during Python 3 support merge, all the
generated Python functions used the general "*args" signature instead of using
the named parameters when possible.

This happened due to is_primitive_defaultargs() always returning false for the
functions without any default arguments as "value" passed to convertValue()
was NULL in this case and convertValue() always returns false for NULL.

Fix this by checking for value being non-NULL before calling convertValue().

Doing this exposed several problems with the handling of unnamed, duplicate
(happens for parameters called INOUT, for example) or clashing with keywords
parameter names, so the code dealing with them had to be fixed too. Basically
just use makeParameterName() consistently everywhere.


  Commit: 15b369028fbfcee559d9f4a8e37e2d71428add29
      https://github.com/swig/swig/commit/15b369028fbfcee559d9f4a8e37e2d71428add29
  Author: Vadim Zeitlin <vz...@ze...>
  Date:   2014-08-17 (Sun, 17 Aug 2014)

  Changed paths:
    M Examples/test-suite/python/default_args_runme.py
    M Source/Modules/python.cxx

  Log Message:
  -----------
  Allow using enum elements as default values for Python functions.

Enum values are just (integer) constants in Python and so can be used as the
function default values just as well as literal numbers, account for this when
checking whether function parameters can be represented in Python.

Also rename is_primitive_defaultargs() to is_representable_as_pyargs() to
describe better what this function does.


  Commit: 36ae32e94115fe7f174ba713458689795bb43196
      https://github.com/swig/swig/commit/36ae32e94115fe7f174ba713458689795bb43196
  Author: William S Fulton <ws...@fu...>
  Date:   2014-10-27 (Mon, 27 Oct 2014)

  Changed paths:
    M Examples/test-suite/python/default_args_runme.py
    M Source/Modules/csharp.cxx
    M Source/Modules/d.cxx
    M Source/Modules/java.cxx
    M Source/Modules/lang.cxx
    M Source/Modules/modula3.cxx
    M Source/Modules/python.cxx
    M Source/Modules/swigmod.h

  Log Message:
  -----------
  Merge remote-tracking branch 'vadz/py-args'

* vadz/py-args:
  Allow using enum elements as default values for Python functions.
  Don't always use "*args" for all Python wrapper functions.
  No real changes, just make PYTHON::check_kwargs() const.
  Refactor: move makeParameterName() to common Language base class.
  Remove long line wrapping from Python parameter list generation code.


  Commit: 5d71f91b291fc1f476f8ea29120cb8413d30c87e
      https://github.com/swig/swig/commit/5d71f91b291fc1f476f8ea29120cb8413d30c87e
  Author: William S Fulton <ws...@fu...>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M Examples/test-suite/python/autodoc_runme.py

  Log Message:
  -----------
  Fix autodoc testcase for new named python arguments when using python -builtin

For the changes in #201.


  Commit: cd725fbe948f39cebb0ce979997cc6bf5ffd2331
      https://github.com/swig/swig/commit/cd725fbe948f39cebb0ce979997cc6bf5ffd2331
  Author: William S Fulton <ws...@fu...>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M Source/Modules/lang.cxx
    M Source/Modules/python.cxx

  Log Message:
  -----------
  Minor cosmetic source code changes


  Commit: a6efdb7999298de6be8c5b4f1fca4ff60ac1fb20
      https://github.com/swig/swig/commit/a6efdb7999298de6be8c5b4f1fca4ff60ac1fb20
  Author: William S Fulton <ws...@fu...>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M Examples/test-suite/keyword_rename.i
    M Examples/test-suite/python/keyword_rename_runme.py
    M Lib/python/pythonkw.swg

  Log Message:
  -----------
  Fix when is 'self' used as a parameter name in Python

Fix corner case for variable names called 'self' after merging in patch #201


Compare: https://github.com/swig/swig/compare/d03c260738bd...a6efdb799929