From: William S F. <ws...@fu...> - 2014-06-20 06:58:25
|
On 16/06/14 16:33, Simon Marchetto wrote: > I've done all of the changes. > Great, thanks. >>>> "Note: in fact, it is not necessary to include the library >>>> typemaps.i, this one is included by default. " This is inconsistent >>>> with the other language, please change it to not include by default. >>>> >>> => I can run the example I gave in the documentation in Scilab and in >>> Python, without including typemaps.i. >>> Is it because this example does not need typemaps.i ? Or because >>> typemaps.i is included by default ? >>> In any case, I did not intend to include it by default. I did a >>> search now, I couldn't find any such include in Lib/scilab, but maybe >>> I missed it. On closer inspection the INPUT, INOUT, OUTPUT typemaps are included by default by some but not all the languages. I think that changed ages ago, so sorry, I'm very out of date. I've a few comments next on the build system... configure.ac: - scilab is not disabled if the header files are not found. - Does scilab not use pkg-config or a scilab-config? Most of the modern scripting language do so that it is easy to find the location of headers and binaries etc. Examples/Makefile.in: - uses abspath... please change to relative path - why do the scilab and scilab_cpp targets check for builder.sce? Don't the examples/test-suite always generate builder.sce? Does it have to set MAKEFLAGS, what is the default parallelisation for the builder? - the scilab_run target shouldn't have an if statement, it should always be run like the other languages - the use of eval and get_swig_scilab_args seems overly complex, can't it just use a simple if? - the swig executable invocation does not use -o - each of the individual example Makefiles sets TARGET to the name of the generated file, it should be the module name. - the contents of INCLUDES in test-suite/scilab/Makefile.in is different to normal, I'm not sure there is a good reason for this, please restore to normal Should Examples/scilab/matrix2/README be checked in? The constants, enum, template and variable examples have deviated from the versions in the other languages. Can you change them to use the identical source input files as say Java/Python. One day I would like common examples source for all different languages. William |