From: <wsf...@us...> - 2012-11-13 22:16:34
|
Revision: 13878 http://swig.svn.sourceforge.net/swig/?rev=13878&view=rev Author: wsfulton Date: 2012-11-13 22:16:28 +0000 (Tue, 13 Nov 2012) Log Message: ----------- Fix some subtle named output typemap lookup misses, the fully qualified name was not always being in all cases such as member variables Modified Paths: -------------- trunk/CHANGES.current trunk/Source/Modules/java.cxx trunk/Source/Modules/lang.cxx trunk/Source/Modules/r.cxx trunk/Source/Swig/parms.c trunk/Source/Swig/swigparm.h trunk/Source/Swig/typemap.c Modified: trunk/CHANGES.current =================================================================== --- trunk/CHANGES.current 2012-11-09 17:57:42 UTC (rev 13877) +++ trunk/CHANGES.current 2012-11-13 22:16:28 UTC (rev 13878) @@ -8,6 +8,27 @@ 2012-11-09: vzeitlin [Python] Fix overflow when passing values greater than LONG_MAX from Python 3 for parameters with unsigned long C type. +2012-11-02: wsfulton + Fix some subtle named output typemap lookup misses, the fully qualified name was not always being + used for variables, for example: + + struct Glob { + int MyVar; + }; + + Previously the search rules (as shown by -debug-tmsearch) for the getter wrapper were: + + example.i:44: Searching for a suitable 'out' typemap for: int MyVar + Looking for: int MyVar + Looking for: int + + Now the scope is named correctly: + + example.i:44: Searching for a suitable 'out' typemap for: int Glob::MyVar + Looking for: int Glob::MyVar + Looking for: int MyVar + Looking for: int + 2012-10-26: wsfulton Fix director typemap searching so that a typemap specified with a name will be correctly matched. Previously the name was ignored during the typemap search. Applies to the following list of typemaps: Modified: trunk/Source/Modules/java.cxx =================================================================== --- trunk/Source/Modules/java.cxx 2012-11-09 17:57:42 UTC (rev 13877) +++ trunk/Source/Modules/java.cxx 2012-11-13 22:16:28 UTC (rev 13878) @@ -3514,7 +3514,6 @@ * --------------------------------------------------------------- */ int classDirectorMethod(Node *n, Node *parent, String *super) { - String *empty_str = NewString(""); String *classname = Getattr(parent, "sym:name"); String *c_classname = Getattr(parent, "name"); String *name = Getattr(n, "name"); @@ -3625,8 +3624,7 @@ String *cdesc = NULL; SwigType *covariant = Getattr(n, "covariant"); SwigType *adjustedreturntype = covariant ? covariant : returntype; - Parm *adjustedreturntypeparm = NewParm(adjustedreturntype, name, n); -// Setattr(adjustedreturntypeparm, "sym:symtab", Getattr(n, "sym:symtab")); + Parm *adjustedreturntypeparm = NewParmNode(adjustedreturntype, n); if ((tm = Swig_typemap_lookup("directorin", adjustedreturntypeparm, "", 0)) && (cdesc = Getattr(adjustedreturntypeparm, "tmap:directorin:descriptor"))) { @@ -3646,7 +3644,7 @@ /* Get the JNI field descriptor for this return type, add the JNI field descriptor to jniret_desc */ if ((c_ret_type = Swig_typemap_lookup("jni", n, "", 0))) { - Parm *tp = NewParm(c_ret_type, name, n); + Parm *tp = NewParmNode(c_ret_type, n); if (!is_void && !ignored_method) { String *jretval_decl = NewStringf("%s jresult", c_ret_type); @@ -3737,7 +3735,7 @@ } /* Start the Java field descriptor for the intermediate class's upcall (insert self object) */ - Parm *tp = NewParm(c_classname, empty_str, n); + Parm *tp = NewParmNode(c_classname, n); String *jdesc; if ((tm = Swig_typemap_lookup("directorin", tp, "", 0)) @@ -3779,7 +3777,7 @@ /* Get parameter's intermediary C type */ if ((c_param_type = Getattr(p, "tmap:jni"))) { - Parm *tp = NewParm(c_param_type, empty_str, n); + Parm *tp = NewParm(c_param_type, Getattr(p, "name"), n); String *desc_tm = NULL, *jdesc = NULL, *cdesc = NULL; /* Add to local variables */ Modified: trunk/Source/Modules/lang.cxx =================================================================== --- trunk/Source/Modules/lang.cxx 2012-11-09 17:57:42 UTC (rev 13877) +++ trunk/Source/Modules/lang.cxx 2012-11-13 22:16:28 UTC (rev 13878) @@ -1419,7 +1419,12 @@ target = NewStringf("%s->%s", pname, name); Delete(pname); } - tm = Swig_typemap_lookup("memberin", n, target, 0); + + // This is an input type typemap lookup and so it should not use Node n + // otherwise qualification is done on the parameter name for the setter function + Parm *nin = NewParm(type, name, n); + tm = Swig_typemap_lookup("memberin", nin, target, 0); + Delete(nin); } int flags = Extend | SmartPointer | use_naturalvar_mode(n); if (isNonVirtualProtectedAccess(n)) Modified: trunk/Source/Modules/r.cxx =================================================================== --- trunk/Source/Modules/r.cxx 2012-11-09 17:57:42 UTC (rev 13877) +++ trunk/Source/Modules/r.cxx 2012-11-13 22:16:28 UTC (rev 13878) @@ -682,7 +682,7 @@ XXX Have to be a little more clever so that we can deal with struct A * - the * is getting lost. Is this still true? If so, will a SwigType_push() solve things? */ - Parm *bbase = NewParm(rettype, Swig_cresult_name(), n); + Parm *bbase = NewParmNode(rettype, n); String *returnTM = Swig_typemap_lookup("in", bbase, Swig_cresult_name(), f); if(returnTM) { String *tm = returnTM; Modified: trunk/Source/Swig/parms.c =================================================================== --- trunk/Source/Swig/parms.c 2012-11-09 17:57:42 UTC (rev 13877) +++ trunk/Source/Swig/parms.c 2012-11-13 22:16:28 UTC (rev 13878) @@ -19,13 +19,13 @@ * NewParm() * * Create a new parameter from datatype 'type' and name 'name' copying - * the file and line number from the Node file_line_node. + * the file and line number from the Node from_node. * ------------------------------------------------------------------------ */ -Parm *NewParm(SwigType *type, const_String_or_char_ptr name, Node *file_line_node) { +Parm *NewParm(SwigType *type, const_String_or_char_ptr name, Node *from_node) { Parm *p = NewParmWithoutFileLineInfo(type, name); - Setfile(p, Getfile(file_line_node)); - Setline(p, Getline(file_line_node)); + Setfile(p, Getfile(from_node)); + Setline(p, Getline(from_node)); return p; } @@ -49,6 +49,20 @@ } /* ------------------------------------------------------------------------ + * NewParmNode() + * + * Create a new parameter from datatype 'type' and name and symbol table as + * well as file and line number from the 'from_node'. + * The resulting Parm will be similar to a Node used for typemap lookups. + * ------------------------------------------------------------------------ */ + +Parm *NewParmNode(SwigType *type, Node *from_node) { + Parm *p = NewParm(type, Getattr(from_node, "name"), from_node); + Setattr(p, "sym:symtab", Getattr(from_node, "sym:symtab")); + return p; +} + +/* ------------------------------------------------------------------------ * CopyParm() * ------------------------------------------------------------------------ */ Modified: trunk/Source/Swig/swigparm.h =================================================================== --- trunk/Source/Swig/swigparm.h 2012-11-09 17:57:42 UTC (rev 13877) +++ trunk/Source/Swig/swigparm.h 2012-11-13 22:16:28 UTC (rev 13878) @@ -13,8 +13,9 @@ * ----------------------------------------------------------------------------- */ /* Individual parameters */ -extern Parm *NewParm(SwigType *type, const_String_or_char_ptr name, Node *file_line_node); +extern Parm *NewParm(SwigType *type, const_String_or_char_ptr name, Node *from_node); extern Parm *NewParmWithoutFileLineInfo(SwigType *type, const_String_or_char_ptr name); +extern Parm *NewParmNode(SwigType *type, Node *from_node); extern Parm *CopyParm(Parm *p); /* Parameter lists */ Modified: trunk/Source/Swig/typemap.c =================================================================== --- trunk/Source/Swig/typemap.c 2012-11-09 17:57:42 UTC (rev 13877) +++ trunk/Source/Swig/typemap.c 2012-11-13 22:16:28 UTC (rev 13878) @@ -1339,7 +1339,17 @@ pname = Getattr(node, "name"); +/* + if (pname && node && Getattr(node, "sym:symtab")) { + if (!checkAttribute(node, "kind", "function")) { + Printf(stdout, "New check: %s %s %s\n", Getattr(node, "name"), nodeType(node), Getattr(node, "kind")); + } + } +*/ + if (pname && node && Getattr(node, "sym:symtab")) { + /* if (pname && node && checkAttribute(node, "kind", "function")) { + */ /* For functions, add on a qualified name search, for example struct Foo { This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |