Menu
▾
▴
[Swig-devel] [ swig-Patches-3571189 ] FIX [ swig-Bugs-3541652 ] Refcount (SmartPointer / Implicit
|
From: SourceForge.net <no...@so...> - 2012-09-26 16:45:14
|
Patches item #3571189, was opened at 2012-09-24 05:59 Message generated for change (Comment added) made by vertrex You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=3571189&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: general Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Solal Jacob (vertrex) Assigned to: Nobody/Anonymous (nobody) Summary: FIX [ swig-Bugs-3541652 ] Refcount (SmartPointer / Implicit Initial Comment: I submitted bugs 3541652 , and I try to fixed it. Also I'm not sure if it's the best way to fix it because I only need to comment/remove two lines of code which for me doesn't do anything (and I'm probably wrong) other than making Swig_Python_ConvertPtrAndOwn unthread-safe. If I'm wrong please give some advices to fix it properly. Thanks. (I included the patch and a test-case based on swig 2.0.8 ---------------------------------------------------------------------- >Comment By: Solal Jacob (vertrex) Date: 2012-09-26 09:45 Message: The file 'second path attempt' avoid the problem of recursion. Instead of setting the implicitconv flags in SwigPyClientData structure it set the flags in the SwigPyObject structure. So the patch this patch avoid the race conditions and the problem of recursion. There is two new test case that show the patch work, but the first test case will still not work as it assign the same object and so it come as using a kind of global flags, but this test case is not really realistic and the variable will still be assigned. Also, I didn't provide the test case for the recursion problem but I tested it on a larger project who use refcounted Variant and the problems of recursion and race condition disappeared. ---------------------------------------------------------------------- Comment By: Solal Jacob (vertrex) Date: 2012-09-24 10:33 Message: It seem that PyObject_CallFunctionObjAgs call Swig_Python_ConvertPtrAndOwn recursively so the patch could certainly broke thins in certain case. I think we must found a way to pass the implicitconv flags (to stop recursion), in a thread safe way. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=3571189&group_id=1645 |