From: William S F. <ws...@fu...> - 2012-06-06 19:31:26
|
On 04/06/12 18:07, Swati Sharma wrote: > *This Week*:[Test-suite Makefile,Support of GNUstep on linux and fixed > rough edges] > > a.Modified Test-suite Makefile. > > For Objective-C there are no cxx files available when a test is run. > There are instead .mm files. And this was causing a problem - the new > targets I added fixes just that. > > b.GNUstep fix for Linux. > The fix incorporates the default objective C flags which should be > passed to GNUstep to compile the code. They were missing earlier.For > this change was required in Source/configuration.in > <http://configuration.in> file. > > c.Changes in Examples./Makefile.in for compiling some broken Examples > SRCS was not getting any value for examples which don't have source file > and compilation stops over there.For this ,I merged two lines of > compilation " one for C/C++ and one for objective C and C++ " .Now the > compilation of Examples don't give an error "No source file". > > d.Removed warnings during GNUstep compilation of Examples > Since assignment inside the if() is the exception, GCC issues a warning > about it.To remove this warning i put the extra paranthesis which really > mean assignment. > > e Memory Leak analysis > Found Objective-C has ownership and the underlying C/C++ object is > deallocated when the Objective-C object is deallocated (swigCMemOwn is > YES.) If swigCMemOwn is No, C/C++ is ultimately responsible for > deallocating the underlying object's memory.But in Objective C it was > set to "NO" and neither the underlying memory for object was deallocated > by C/C++.Till the time i set swigCMemOwn to "YES",But,this requires > proper fix.This is my next week commitment. > > *Commits:* > a.http://swig.svn.sourceforge.net/viewvc/swig?view=revision&revision=13139 > <http://swig.svn.sourceforge.net/viewvc/swig?view=revision&revision=13139> For this commit, can you not use the swig_and_compile_cpp and swig_and_compile_c targets in common.mk instead like most of the other languages? A superficial scan seems that you can. It is better to use common.mk as much as possible. William |