[sweep-devel] speex_header_to_packet() fix

[Conrad P. <co...@me...>]

Hi,

I just committed a small fix to trunk, reported by Jean-Marc Valin. It
should fix a potential bug when saving as Speex on some 64 bit platforms.

It's a one liner, changing a long to int. The initialization seems to
be a little unnecessary but has always been there. Mostly harmless,
please test :-)

Conrad.

conrad@saru-chan:~/src/metadecks.org/sweep$ svn log --limit 1
------------------------------------------------------------------------
r439 | conrad | 2006-11-24 13:41:37 +0900 (金, 24 11月 2006) | 8 lines

fix type of length passed to speex_header_to_packet()
Bug reported by Jean-Marc Valin:

<jmworx> kfish: I think I found a bug in sweep with the way it uses
speex_header_to_packet()
<jmworx> basically, the last argument is an int* and you pass a long*.
Works fine on 32-bit archs (and maybe some 64-bit ones), but
eventually you'll run into problems.
<jmworx> In any case, the fix is *probably* to just use an int for the
size argument. You just need to make sure it won't break something
else (haven't checked).
<jmworx> speexenc was passing ogg_packet.size directly, which was
wrong. You did things sort of the right way (declare the size
separately), but just didn't use the right type.

------------------------------------------------------------------------