[sweep-devel] Re: Sweep

[Conrad P. <co...@ve...>]

On Wed, Oct 25, 2000 at 08:26:34PM +0300, Juhana Sadeharju wrote:
> Hello.
> 
> Here are further feedback for Sweep. If you wish, you may post to
> Sweep's developer mailing list -- it okay for me.
> 
> I may later make some tutorial on editing to your webpages. Just
> showing how I practically use the editor.

that would be great.

> Feedback follows:
> 
>  -I got a compilation warning:
>    driver.c: In function `play_view':
>    driver.c:383: warning: implicit declaration of function `memset'
> 
> Nothing severe, guess.

cool, now fixed in CVS

>  -Support for raw audiofiles; for example, my recorder alsashmrec and
>   cdparanoia outputs 44100 Hz, 16-bit ("short" in C works), stereo files;
> 
> I use raw files because large files are easily splitted to smaller
> files with tail and head programs. When we will have a good recorder/editor
> available, I sure will forget any raw formats --- some simple temporary
> solution would be enough.

notd (Bug #119648)

> How difficult is it to write a raw file load plug-in?

at the moment file loading isn't done via plugins

the code would be pretty easy of course. also the load/save dialogs need
file type menus, which they currently don't have.

>  -The waveform display has poor colors:
> ...

YES it does! I'd love some new colours

>     -what is this yellow color afterall? A mean power of signal?
>      it is good but its color is fading into the waveform color

yes, the yellow is the mean and the green is peak

> More better colors would be good. In my editor I use white background with
> black waveform --- it is better for eyes than the 3D thing you have.
> I include a screenshot of Sweep session at "http://www.funet.fi/~kouhia/
> sweep1.jpg" --- if you get different colors, the problem is elsewhere.

that looks just like here ;)

you mentioned another problem with selections not being visible till you
release the mouse, which indicates you might have way lower contrast in
your display than I can see. (The selection should be dark gray until you
release).

we need new colours though :)

>  -Playing starting from the pointer to end of wave
> 
> That has been done in SoundForge.

noted (added to bug #117594)

>  -Moving playline during playing
> 
> The audio engine should send events to the GUI so that the GUI can draw the
> playline to correct place at the right moment. Storing the position info
> in shared memory plus a periodic call (10 times per second) of playline
> drawing routine could work better.

the code has been changed to use a timeout rather than running in the idle
loop (by Darragh O'brien, a couple of days ago)

it should get the current playback position from the device rather than just
reporting on what's been written (which is always ahead of what the user
hears).

>  -There is something wrong in selection making; if I quickly sweep
>   the selection, then the first selection edge is not at the place where
>   the button press happened
> 
> I took a look at the source code but could not help.

noted (bug #119650)

>  -Zoom tool could change the pointer to "+" when zoom-in is active,
>   and to "-" when zoom-out is active (i.e., when shift is hold down)
> 
> Adobe's acroread has that kind of zoom tool pointer.

cool idea :) noted in bug #119651

>  -Zoom-in seems to double but zoom-out not; it would be good if the same
>   amount of button presses are needed when zooming in and when zooming out
>   back to the original zoom ratio

I redid the zoom code a couple of days ago, it _should_ work the way you
describe, let me know if it there's still a problem

>  -change the default Zoom-in/out with respect to pointer; i.e., the
>   zoom-in place would not move to center of display, but would stay
>   at pointer location

done for the zoom tool, perhaps normal +/- zooming should work this way
too?

>  -*-
> 
> That's all this time. By the way, for some reason Sweep spends a lot of
> CPU power and X is jamming. Mouse movement was really jamming and I had
> to quit Sweep.

damn ants are unfit, they need to lose some weight.

thanks for the feedback :)

Conrad.