Re: [SCM] strace branch, master, updated. v4.10-25-g8497b62

[Denys V. <dvl...@re...>]

On 04/07/2015 02:08 AM, Dmitry V. Levin wrote:
> On Tue, Mar 24, 2015 at 05:13:13AM +0300, Dmitry V. Levin wrote:
>> It also doesn't work on alpha and s390/s390x:
>>
>> $ sleep 2 & sleep 1; ./strace -erestart_syscall -p $!
>> [1] 12345
>> Process 12345 attached
>> restart_syscall(<... resuming interrupted unknown ...>) = 0
>> +++ exited with 0 +++
>> [1]+  Done                    sleep 2
> 
> I think this "resuming interrupted unknown" message is confusing.

Yes, looks wrong. Can't reproduce it here, tho:

$ sleep 5 & sleep 4; ./strace -erestart_syscall -p $!
Process 26088 attached
[ Process PID=26088 runs in 32 bit mode. ]
restart_syscall(<... resuming interrupted nanosleep ...>) = 0
+++ exited with 0 +++


> If you could find a better fix than this, please apply it.

I'm going to apply this:

--- a/syscall.c
+++ b/syscall.c
@@ -1264,7 +1264,7 @@ get_scno(struct tcb *tcp)
                        .nargs = MAX_ARGS,
                        .sys_flags = 0,
                        .sys_func = printargs,
-                       .sys_name = "unknown", /* not used */
+                       .sys_name = "system call",
                };
                tcp->s_ent = &unknown;