Re: improved SI_TIMER decoding

[Mike F. <va...@ge...>]

On Thu 06 Mar 2014 18:20:50 enh wrote:
> Decode siginfo_t more clearly for si_code SI_TIMER.
> 
> The 'pid' is actually a POSIX timer id, and the 'uid' is actually the
> overrun.
> 
> Also factor out the si_value dumping so it's the same for every si_code.

please use `git send-email` rather than attaching (and doing base64 encoding 
of) your patches.  it makes it much harder to do reviews when it's like this.

> @@ -561,32 +572,35 @@ printsiginfo(siginfo_t *sip, int verbose)
>  		}
>  #ifdef SI_FROMUSER
>  		if (SI_FROMUSER(sip)) {
> -			tprintf(", si_pid=%lu, si_uid=%lu",
> -				(unsigned long) sip->si_pid,
> -				(unsigned long) sip->si_uid);
>  			switch (sip->si_code) {
>  #ifdef SI_USER
>  			case SI_USER:
> +				tprintf(", si_pid=%lu, si_uid=%lu",
> +					(unsigned long) sip->si_pid,
> +					(unsigned long) sip->si_uid);
>  				break;
>  #endif
>  #ifdef SI_TKILL
>  			case SI_TKILL:
> +				tprintf(", si_pid=%lu, si_uid=%lu",
> +					(unsigned long) sip->si_pid,
> +					(unsigned long) sip->si_uid);
>  				break;
>  #endif

well, now the output handling for source signals has been duplicated 3 times.  
that doesn't seem like an improvement.  why not split the logic for decoding 
of the source and decoding of the value so there's no duplication ?

>  			default:
> +			tprintf(", si_pid=%lu, si_uid=%lu",
> +				(unsigned long) sip->si_pid,
> +				(unsigned long) sip->si_uid);

indent here is incorrect
-mike