Re: How about removing non-Linux code?

[Dmitry V. L. <ld...@al...>]

On Sat, Feb 25, 2012 at 03:49:03PM +0100, Denys Vlasenko wrote:
> On 02/25/2012 02:51 PM, Denys Vlasenko wrote:
> > On 02/25/2012 01:41 AM, Dmitry V. Levin wrote:
> >> On Wed, Feb 22, 2012 at 05:40:46AM +0400, Dmitry V. Levin wrote:
> >>> So, since there were no objections, let's go ahead and kick the dead code out.
> >>
> >> Here it is, tested on x86 and x86-64, please have a look (6 top commits):
> >> http://strace.git.sourceforge.net/git/gitweb.cgi?p=strace/strace;a=shortlog;h=ldv/unifdef
> >
> > Eh.... I committed the removal just this night :/
> > You said:
> >
> >   >  So, since there were no objections, let's go ahead and kick the dead code out.
> >
> > and I took it as a green light...
> >
> > Ok, I am looking at your changes; meanwhile, please look at current git
> > and let me know what do you think about mine.
> 
> Looks like them biggest difference between our trees is how we dealt with
> svr4/ directory. You left it intact, while I copied three files to
> sparc/ (errnoent1.h, ioctlent1.h and signalent1.h) and deleted svr4/
> altogether.
> 
> I am not feeling zealous about it. If you prefer svr4/ to stay, I'm ok with
> reverting it to that state.
> 
> I cherry-picked a number of good changes from your branch and committed them
> to the master.
> 
> The remaining diff is below. Apart from trivial differences in ifdef formats,
> there is a difference that I dropped LINUX_X86_64, LINUX_ARM and LINUX_AVR32
> defines since they are always the same as X86_64, ARM and AVR32.

OK for me.  The remaining differences are trivial.


-- 
ldv