Re: [Stlport-devel] C Macro fixes

[Petr O. <pt...@is...>]

On Thursday 14 June 2007 23:51, François Dumont wrote:
> Hi
> 
>     I just replace test/unit/cwchar.cpp by test/unit/macro_checks.cpp. 
> This file now contains checks for (almost) all C Standard macros, it 
> checks that the macro is defined and that its value can be used in a 
> test at preprocessing time.
> 
>     Now the question is: where should macro definition should take place 
> ? There are 2 possibilities:
> 1. Those macros are C ones so fixes must be in the C Standard headers.
> 2. STLport is a C++ Standard library implementation so it only brings 
> fixes for C++ applications. Fixes has to be in the C++ counterparts of 
> the C Standard header (cwchar for wchar.h for instance)
> 
> For the moment 2 is in use, I would prefer 1 for consistency between C 
> and C++ worlds.

Well, following case 1 really lead to 'inconsistency between C and C++ worlds'.
Reason: definition should be same for C and C++, but we don't fix system
headers, even if ones wrong. So attempt to fix C part in STLport will
lead to different interpretation for C (without STLport, normal behaviour)
and C++ (with STLport) code. So I consider only case 2 as practical. Make sense?


   - ptr