From: Mike S. <oop...@gm...> - 2009-02-27 03:16:56
Attachments:
searcher.diff
|
Hi everyone, I worked on a complete redesign of the searching logic behind SearchDialog, so that it is separated from the UI. This allows several improvements, the most important of which are: we can very easily add new data to search, and search results are full StelObjects. To create a new search method, just subclass Searcher and SearcherReply and call SearchMgr::addSearcher(Searcher*). This also simplifies the SearchDialog code greatly. I think this way is much more elegant, without any loss in functionality. Other classes and plugins can now use StelSearchMgr, as well. I've attached the code as a patch, because I'd rather get some feedback and approval before committing it. The patch was diff'd against rev 4298. P.S. I only added the "Show details" button as a demo. We can easily remove it if necessary. Cheers, Mike |
From: Bogdan M. <dag...@gm...> - 2009-02-27 12:36:29
|
Hi, Mike. It seems that the code for the StelSearchMgr class is not in your patch, so it's impossible to build it. :) Bogdan On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: > Hi everyone, > > I worked on a complete redesign of the searching logic behind > SearchDialog, so that it is separated from the UI. This allows several > improvements, the most important of which are: we can very easily add > new data to search, and search results are full StelObjects. To create > a new search method, just subclass Searcher and SearcherReply and call > SearchMgr::addSearcher(Searcher*). This also simplifies the > SearchDialog code greatly. > > I think this way is much more elegant, without any loss in > functionality. Other classes and plugins can now use StelSearchMgr, as > well. I've attached the code as a patch, because I'd rather get some > feedback and approval before committing it. The patch was diff'd > against rev 4298. > > P.S. I only added the "Show details" button as a demo. We can easily > remove it if necessary. > > Cheers, > Mike > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > > |
From: Mike S. <oop...@gm...> - 2009-02-27 18:24:31
Attachments:
searcher.diff
|
That's odd. I must had svn add'ed them after I created the patch. Here's an updated version. Mike On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: > Hi, Mike. > > It seems that the code for the StelSearchMgr class is not in your > patch, so it's impossible to build it. :) > > Bogdan > > On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >> Hi everyone, >> >> I worked on a complete redesign of the searching logic behind >> SearchDialog, so that it is separated from the UI. This allows several >> improvements, the most important of which are: we can very easily add >> new data to search, and search results are full StelObjects. To create >> a new search method, just subclass Searcher and SearcherReply and call >> SearchMgr::addSearcher(Searcher*). This also simplifies the >> SearchDialog code greatly. >> >> I think this way is much more elegant, without any loss in >> functionality. Other classes and plugins can now use StelSearchMgr, as >> well. I've attached the code as a patch, because I'd rather get some >> feedback and approval before committing it. The patch was diff'd >> against rev 4298. >> >> P.S. I only added the "Show details" button as a demo. We can easily >> remove it if necessary. >> >> Cheers, >> Mike >> >> ------------------------------------------------------------------------------ >> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >> -Strategies to boost innovation and cut costs with open source participation >> -Receive a $600 discount off the registration fee with the source code: SFAD >> http://p.sf.net/sfu/XcvMzF8H >> _______________________________________________ >> Stellarium-pubdevel mailing list >> Ste...@li... >> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> >> > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Mike S. <oop...@gm...> - 2009-02-28 07:50:25
|
If there are no objections, I'll go ahead and commit. Mike On Fri, Feb 27, 2009 at 12:24 PM, Mike Storm <oop...@gm...> wrote: > That's odd. I must had svn add'ed them after I created the patch. > Here's an updated version. > > Mike > > On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: >> Hi, Mike. >> >> It seems that the code for the StelSearchMgr class is not in your >> patch, so it's impossible to build it. :) >> >> Bogdan >> >> On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >>> Hi everyone, >>> >>> I worked on a complete redesign of the searching logic behind >>> SearchDialog, so that it is separated from the UI. This allows several >>> improvements, the most important of which are: we can very easily add >>> new data to search, and search results are full StelObjects. To create >>> a new search method, just subclass Searcher and SearcherReply and call >>> SearchMgr::addSearcher(Searcher*). This also simplifies the >>> SearchDialog code greatly. >>> >>> I think this way is much more elegant, without any loss in >>> functionality. Other classes and plugins can now use StelSearchMgr, as >>> well. I've attached the code as a patch, because I'd rather get some >>> feedback and approval before committing it. The patch was diff'd >>> against rev 4298. >>> >>> P.S. I only added the "Show details" button as a demo. We can easily >>> remove it if necessary. >>> >>> Cheers, >>> Mike >>> >>> ------------------------------------------------------------------------------ >>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>> -Strategies to boost innovation and cut costs with open source participation >>> -Receive a $600 discount off the registration fee with the source code: SFAD >>> http://p.sf.net/sfu/XcvMzF8H >>> _______________________________________________ >>> Stellarium-pubdevel mailing list >>> Ste...@li... >>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>> >>> >> >> ------------------------------------------------------------------------------ >> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >> -Strategies to boost innovation and cut costs with open source participation >> -Receive a $600 discount off the registration fee with the source code: SFAD >> http://p.sf.net/sfu/XcvMzF8H >> _______________________________________________ >> Stellarium-pubdevel mailing list >> Ste...@li... >> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> > |
From: Fabien C. <fab...@go...> - 2009-02-28 13:23:57
|
Please wait, I want to have a look before. Fabien On Sat, Feb 28, 2009 at 8:50 AM, Mike Storm <oop...@gm...> wrote: > If there are no objections, I'll go ahead and commit. > > Mike > > On Fri, Feb 27, 2009 at 12:24 PM, Mike Storm <oop...@gm...> wrote: >> That's odd. I must had svn add'ed them after I created the patch. >> Here's an updated version. >> >> Mike >> >> On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: >>> Hi, Mike. >>> >>> It seems that the code for the StelSearchMgr class is not in your >>> patch, so it's impossible to build it. :) >>> >>> Bogdan >>> >>> On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >>>> Hi everyone, >>>> >>>> I worked on a complete redesign of the searching logic behind >>>> SearchDialog, so that it is separated from the UI. This allows several >>>> improvements, the most important of which are: we can very easily add >>>> new data to search, and search results are full StelObjects. To create >>>> a new search method, just subclass Searcher and SearcherReply and call >>>> SearchMgr::addSearcher(Searcher*). This also simplifies the >>>> SearchDialog code greatly. >>>> >>>> I think this way is much more elegant, without any loss in >>>> functionality. Other classes and plugins can now use StelSearchMgr, as >>>> well. I've attached the code as a patch, because I'd rather get some >>>> feedback and approval before committing it. The patch was diff'd >>>> against rev 4298. >>>> >>>> P.S. I only added the "Show details" button as a demo. We can easily >>>> remove it if necessary. >>>> >>>> Cheers, >>>> Mike >>>> >>>> ------------------------------------------------------------------------------ >>>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>>> -Strategies to boost innovation and cut costs with open source participation >>>> -Receive a $600 discount off the registration fee with the source code: SFAD >>>> http://p.sf.net/sfu/XcvMzF8H >>>> _______________________________________________ >>>> Stellarium-pubdevel mailing list >>>> Ste...@li... >>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>>> >>>> >>> >>> ------------------------------------------------------------------------------ >>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>> -Strategies to boost innovation and cut costs with open source participation >>> -Receive a $600 discount off the registration fee with the source code: SFAD >>> http://p.sf.net/sfu/XcvMzF8H >>> _______________________________________________ >>> Stellarium-pubdevel mailing list >>> Ste...@li... >>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>> >> > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Fabien C. <fab...@go...> - 2009-02-28 17:04:59
|
OK, I had a detailed look at your patch. I like the general idea, and I also like you code style and comments. However I think the classes you created somewhat mirror the current ones: It looks to me that the feature brought by StelSearchMgr should be just new methods added to the StelObjectMgr, similariy, the Searcher class feature to allow for asynchronous searches could just be merged with the StelObjectModule class by adding the necessary method (the lookup() one) This design would respect the current stellarium design and avoid creating a lot of new API. The last problem is the management of StelObject created on the fly by Simbad lookups, a On Sat, Feb 28, 2009 at 1:23 PM, Fabien Chéreau <fab...@go...> wrote: > Please wait, > I want to have a look before. > Fabien > > On Sat, Feb 28, 2009 at 8:50 AM, Mike Storm <oop...@gm...> wrote: >> If there are no objections, I'll go ahead and commit. >> >> Mike >> >> On Fri, Feb 27, 2009 at 12:24 PM, Mike Storm <oop...@gm...> wrote: >>> That's odd. I must had svn add'ed them after I created the patch. >>> Here's an updated version. >>> >>> Mike >>> >>> On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: >>>> Hi, Mike. >>>> >>>> It seems that the code for the StelSearchMgr class is not in your >>>> patch, so it's impossible to build it. :) >>>> >>>> Bogdan >>>> >>>> On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >>>>> Hi everyone, >>>>> >>>>> I worked on a complete redesign of the searching logic behind >>>>> SearchDialog, so that it is separated from the UI. This allows several >>>>> improvements, the most important of which are: we can very easily add >>>>> new data to search, and search results are full StelObjects. To create >>>>> a new search method, just subclass Searcher and SearcherReply and call >>>>> SearchMgr::addSearcher(Searcher*). This also simplifies the >>>>> SearchDialog code greatly. >>>>> >>>>> I think this way is much more elegant, without any loss in >>>>> functionality. Other classes and plugins can now use StelSearchMgr, as >>>>> well. I've attached the code as a patch, because I'd rather get some >>>>> feedback and approval before committing it. The patch was diff'd >>>>> against rev 4298. >>>>> >>>>> P.S. I only added the "Show details" button as a demo. We can easily >>>>> remove it if necessary. >>>>> >>>>> Cheers, >>>>> Mike >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>>>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>>>> -Strategies to boost innovation and cut costs with open source participation >>>>> -Receive a $600 discount off the registration fee with the source code: SFAD >>>>> http://p.sf.net/sfu/XcvMzF8H >>>>> _______________________________________________ >>>>> Stellarium-pubdevel mailing list >>>>> Ste...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>>>> >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>>> -Strategies to boost innovation and cut costs with open source participation >>>> -Receive a $600 discount off the registration fee with the source code: SFAD >>>> http://p.sf.net/sfu/XcvMzF8H >>>> _______________________________________________ >>>> Stellarium-pubdevel mailing list >>>> Ste...@li... >>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>>> >>> >> >> ------------------------------------------------------------------------------ >> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >> -Strategies to boost innovation and cut costs with open source participation >> -Receive a $600 discount off the registration fee with the source code: SFAD >> http://p.sf.net/sfu/XcvMzF8H >> _______________________________________________ >> Stellarium-pubdevel mailing list >> Ste...@li... >> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> > |
From: Fabien C. <fab...@go...> - 2009-02-28 17:09:33
|
Oups, I sent the email by mistake, here is the rest: On Sat, Feb 28, 2009 at 6:04 PM, Fabien Chéreau <fab...@go...> wrote: > OK, > I had a detailed look at your patch. I like the general idea, and I > also like you code style and comments. However I think the classes you > created somewhat mirror the current ones: It looks to me that the > feature brought by StelSearchMgr should be just new methods added to > the StelObjectMgr, similariy, the Searcher class feature to allow for > asynchronous searches could just be merged with the StelObjectModule > class by adding the necessary method (the lookup() one) > This design would respect the current stellarium design and avoid > creating a lot of new API. > > The last problem is the management of StelObject created on the fly by > Simbad lookups, a In this case the most natural design would simply to make the SimbadSearcher derive from StelObjectModule, which would in turn implement the required search features. It could as well allow to display the query result visually on the screen, which could be very useful. In fact I just realize that this definitely was the proper design to adopt from the beginning, but could find this out before you did this good work :) What do you think? Fabien > On Sat, Feb 28, 2009 at 1:23 PM, Fabien Chéreau > <fab...@go...> wrote: >> Please wait, >> I want to have a look before. >> Fabien >> >> On Sat, Feb 28, 2009 at 8:50 AM, Mike Storm <oop...@gm...> wrote: >>> If there are no objections, I'll go ahead and commit. >>> >>> Mike >>> >>> On Fri, Feb 27, 2009 at 12:24 PM, Mike Storm <oop...@gm...> wrote: >>>> That's odd. I must had svn add'ed them after I created the patch. >>>> Here's an updated version. >>>> >>>> Mike >>>> >>>> On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: >>>>> Hi, Mike. >>>>> >>>>> It seems that the code for the StelSearchMgr class is not in your >>>>> patch, so it's impossible to build it. :) >>>>> >>>>> Bogdan >>>>> >>>>> On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >>>>>> Hi everyone, >>>>>> >>>>>> I worked on a complete redesign of the searching logic behind >>>>>> SearchDialog, so that it is separated from the UI. This allows several >>>>>> improvements, the most important of which are: we can very easily add >>>>>> new data to search, and search results are full StelObjects. To create >>>>>> a new search method, just subclass Searcher and SearcherReply and call >>>>>> SearchMgr::addSearcher(Searcher*). This also simplifies the >>>>>> SearchDialog code greatly. >>>>>> >>>>>> I think this way is much more elegant, without any loss in >>>>>> functionality. Other classes and plugins can now use StelSearchMgr, as >>>>>> well. I've attached the code as a patch, because I'd rather get some >>>>>> feedback and approval before committing it. The patch was diff'd >>>>>> against rev 4298. >>>>>> >>>>>> P.S. I only added the "Show details" button as a demo. We can easily >>>>>> remove it if necessary. >>>>>> >>>>>> Cheers, >>>>>> Mike |
From: Mike S. <oop...@gm...> - 2009-02-28 18:58:27
|
Hi Fabien, Yes, I figured you would say that. I only realized how similar StelSearchMgr and StelObjectMgr were after almost completing the work, but I thought I would just send the patch and merge them later. Your solution is almost exactly what I had in mind. I'll work on it. Mike On Sat, Feb 28, 2009 at 11:09 AM, Fabien Chéreau <fab...@go...> wrote: > Oups, I sent the email by mistake, here is the rest: > > > > On Sat, Feb 28, 2009 at 6:04 PM, Fabien Chéreau > <fab...@go...> wrote: >> OK, >> I had a detailed look at your patch. I like the general idea, and I >> also like you code style and comments. However I think the classes you >> created somewhat mirror the current ones: It looks to me that the >> feature brought by StelSearchMgr should be just new methods added to >> the StelObjectMgr, similariy, the Searcher class feature to allow for >> asynchronous searches could just be merged with the StelObjectModule >> class by adding the necessary method (the lookup() one) >> This design would respect the current stellarium design and avoid >> creating a lot of new API. >> >> The last problem is the management of StelObject created on the fly by >> Simbad lookups, a > > In this case the most natural design would simply to make the > SimbadSearcher derive from StelObjectModule, which would in turn > implement the required search features. It could as well allow to > display the query result visually on the screen, which could be very > useful. > In fact I just realize that this definitely was the proper design to > adopt from the beginning, but could find this out before you did this > good work :) > > What do you think? > > Fabien > >> On Sat, Feb 28, 2009 at 1:23 PM, Fabien Chéreau >> <fab...@go...> wrote: >>> Please wait, >>> I want to have a look before. >>> Fabien >>> >>> On Sat, Feb 28, 2009 at 8:50 AM, Mike Storm <oop...@gm...> wrote: >>>> If there are no objections, I'll go ahead and commit. >>>> >>>> Mike >>>> >>>> On Fri, Feb 27, 2009 at 12:24 PM, Mike Storm <oop...@gm...> wrote: >>>>> That's odd. I must had svn add'ed them after I created the patch. >>>>> Here's an updated version. >>>>> >>>>> Mike >>>>> >>>>> On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: >>>>>> Hi, Mike. >>>>>> >>>>>> It seems that the code for the StelSearchMgr class is not in your >>>>>> patch, so it's impossible to build it. :) >>>>>> >>>>>> Bogdan >>>>>> >>>>>> On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >>>>>>> Hi everyone, >>>>>>> >>>>>>> I worked on a complete redesign of the searching logic behind >>>>>>> SearchDialog, so that it is separated from the UI. This allows several >>>>>>> improvements, the most important of which are: we can very easily add >>>>>>> new data to search, and search results are full StelObjects. To create >>>>>>> a new search method, just subclass Searcher and SearcherReply and call >>>>>>> SearchMgr::addSearcher(Searcher*). This also simplifies the >>>>>>> SearchDialog code greatly. >>>>>>> >>>>>>> I think this way is much more elegant, without any loss in >>>>>>> functionality. Other classes and plugins can now use StelSearchMgr, as >>>>>>> well. I've attached the code as a patch, because I'd rather get some >>>>>>> feedback and approval before committing it. The patch was diff'd >>>>>>> against rev 4298. >>>>>>> >>>>>>> P.S. I only added the "Show details" button as a demo. We can easily >>>>>>> remove it if necessary. >>>>>>> >>>>>>> Cheers, >>>>>>> Mike > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Fabien C. <fab...@go...> - 2009-03-03 11:44:49
|
What is the status on this? If we want to include the new feature in 0.10.2, it should be committed soon so that we can perform extended testing. Fabien On Sat, Feb 28, 2009 at 7:58 PM, Mike Storm <oop...@gm...> wrote: > Hi Fabien, > > Yes, I figured you would say that. I only realized how similar > StelSearchMgr and StelObjectMgr were after almost completing the work, > but I thought I would just send the patch and merge them later. Your > solution is almost exactly what I had in mind. I'll work on it. > > Mike > > On Sat, Feb 28, 2009 at 11:09 AM, Fabien Chéreau > <fab...@go...> wrote: >> Oups, I sent the email by mistake, here is the rest: >> >> >> >> On Sat, Feb 28, 2009 at 6:04 PM, Fabien Chéreau >> <fab...@go...> wrote: >>> OK, >>> I had a detailed look at your patch. I like the general idea, and I >>> also like you code style and comments. However I think the classes you >>> created somewhat mirror the current ones: It looks to me that the >>> feature brought by StelSearchMgr should be just new methods added to >>> the StelObjectMgr, similariy, the Searcher class feature to allow for >>> asynchronous searches could just be merged with the StelObjectModule >>> class by adding the necessary method (the lookup() one) >>> This design would respect the current stellarium design and avoid >>> creating a lot of new API. >>> >>> The last problem is the management of StelObject created on the fly by >>> Simbad lookups, a >> >> In this case the most natural design would simply to make the >> SimbadSearcher derive from StelObjectModule, which would in turn >> implement the required search features. It could as well allow to >> display the query result visually on the screen, which could be very >> useful. >> In fact I just realize that this definitely was the proper design to >> adopt from the beginning, but could find this out before you did this >> good work :) >> >> What do you think? >> >> Fabien >> >>> On Sat, Feb 28, 2009 at 1:23 PM, Fabien Chéreau >>> <fab...@go...> wrote: >>>> Please wait, >>>> I want to have a look before. >>>> Fabien >>>> >>>> On Sat, Feb 28, 2009 at 8:50 AM, Mike Storm <oop...@gm...> wrote: >>>>> If there are no objections, I'll go ahead and commit. >>>>> >>>>> Mike >>>>> >>>>> On Fri, Feb 27, 2009 at 12:24 PM, Mike Storm <oop...@gm...> wrote: >>>>>> That's odd. I must had svn add'ed them after I created the patch. >>>>>> Here's an updated version. >>>>>> >>>>>> Mike >>>>>> >>>>>> On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: >>>>>>> Hi, Mike. >>>>>>> >>>>>>> It seems that the code for the StelSearchMgr class is not in your >>>>>>> patch, so it's impossible to build it. :) >>>>>>> >>>>>>> Bogdan >>>>>>> >>>>>>> On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >>>>>>>> Hi everyone, >>>>>>>> >>>>>>>> I worked on a complete redesign of the searching logic behind >>>>>>>> SearchDialog, so that it is separated from the UI. This allows several >>>>>>>> improvements, the most important of which are: we can very easily add >>>>>>>> new data to search, and search results are full StelObjects. To create >>>>>>>> a new search method, just subclass Searcher and SearcherReply and call >>>>>>>> SearchMgr::addSearcher(Searcher*). This also simplifies the >>>>>>>> SearchDialog code greatly. >>>>>>>> >>>>>>>> I think this way is much more elegant, without any loss in >>>>>>>> functionality. Other classes and plugins can now use StelSearchMgr, as >>>>>>>> well. I've attached the code as a patch, because I'd rather get some >>>>>>>> feedback and approval before committing it. The patch was diff'd >>>>>>>> against rev 4298. >>>>>>>> >>>>>>>> P.S. I only added the "Show details" button as a demo. We can easily >>>>>>>> remove it if necessary. >>>>>>>> >>>>>>>> Cheers, >>>>>>>> Mike >> >> ------------------------------------------------------------------------------ >> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >> -Strategies to boost innovation and cut costs with open source participation >> -Receive a $600 discount off the registration fee with the source code: SFAD >> http://p.sf.net/sfu/XcvMzF8H >> _______________________________________________ >> Stellarium-pubdevel mailing list >> Ste...@li... >> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Mike S. <oop...@gm...> - 2009-03-03 15:24:37
|
I think it'll have to go 0.10.3, since I don't have time to finish it at the moment (i.e., within the next 24 hours). Mike On Tue, Mar 3, 2009 at 5:44 AM, Fabien Chéreau <fab...@go...> wrote: > What is the status on this? If we want to include the new feature in > 0.10.2, it should be committed soon so that we can perform extended > testing. > Fabien > > On Sat, Feb 28, 2009 at 7:58 PM, Mike Storm <oop...@gm...> wrote: >> Hi Fabien, >> >> Yes, I figured you would say that. I only realized how similar >> StelSearchMgr and StelObjectMgr were after almost completing the work, >> but I thought I would just send the patch and merge them later. Your >> solution is almost exactly what I had in mind. I'll work on it. >> >> Mike >> >> On Sat, Feb 28, 2009 at 11:09 AM, Fabien Chéreau >> <fab...@go...> wrote: >>> Oups, I sent the email by mistake, here is the rest: >>> >>> >>> >>> On Sat, Feb 28, 2009 at 6:04 PM, Fabien Chéreau >>> <fab...@go...> wrote: >>>> OK, >>>> I had a detailed look at your patch. I like the general idea, and I >>>> also like you code style and comments. However I think the classes you >>>> created somewhat mirror the current ones: It looks to me that the >>>> feature brought by StelSearchMgr should be just new methods added to >>>> the StelObjectMgr, similariy, the Searcher class feature to allow for >>>> asynchronous searches could just be merged with the StelObjectModule >>>> class by adding the necessary method (the lookup() one) >>>> This design would respect the current stellarium design and avoid >>>> creating a lot of new API. >>>> >>>> The last problem is the management of StelObject created on the fly by >>>> Simbad lookups, a >>> >>> In this case the most natural design would simply to make the >>> SimbadSearcher derive from StelObjectModule, which would in turn >>> implement the required search features. It could as well allow to >>> display the query result visually on the screen, which could be very >>> useful. >>> In fact I just realize that this definitely was the proper design to >>> adopt from the beginning, but could find this out before you did this >>> good work :) >>> >>> What do you think? >>> >>> Fabien >>> >>>> On Sat, Feb 28, 2009 at 1:23 PM, Fabien Chéreau >>>> <fab...@go...> wrote: >>>>> Please wait, >>>>> I want to have a look before. >>>>> Fabien >>>>> >>>>> On Sat, Feb 28, 2009 at 8:50 AM, Mike Storm <oop...@gm...> wrote: >>>>>> If there are no objections, I'll go ahead and commit. >>>>>> >>>>>> Mike >>>>>> >>>>>> On Fri, Feb 27, 2009 at 12:24 PM, Mike Storm <oop...@gm...> wrote: >>>>>>> That's odd. I must had svn add'ed them after I created the patch. >>>>>>> Here's an updated version. >>>>>>> >>>>>>> Mike >>>>>>> >>>>>>> On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: >>>>>>>> Hi, Mike. >>>>>>>> >>>>>>>> It seems that the code for the StelSearchMgr class is not in your >>>>>>>> patch, so it's impossible to build it. :) >>>>>>>> >>>>>>>> Bogdan >>>>>>>> >>>>>>>> On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >>>>>>>>> Hi everyone, >>>>>>>>> >>>>>>>>> I worked on a complete redesign of the searching logic behind >>>>>>>>> SearchDialog, so that it is separated from the UI. This allows several >>>>>>>>> improvements, the most important of which are: we can very easily add >>>>>>>>> new data to search, and search results are full StelObjects. To create >>>>>>>>> a new search method, just subclass Searcher and SearcherReply and call >>>>>>>>> SearchMgr::addSearcher(Searcher*). This also simplifies the >>>>>>>>> SearchDialog code greatly. >>>>>>>>> >>>>>>>>> I think this way is much more elegant, without any loss in >>>>>>>>> functionality. Other classes and plugins can now use StelSearchMgr, as >>>>>>>>> well. I've attached the code as a patch, because I'd rather get some >>>>>>>>> feedback and approval before committing it. The patch was diff'd >>>>>>>>> against rev 4298. >>>>>>>>> >>>>>>>>> P.S. I only added the "Show details" button as a demo. We can easily >>>>>>>>> remove it if necessary. >>>>>>>>> >>>>>>>>> Cheers, >>>>>>>>> Mike >>> >>> ------------------------------------------------------------------------------ >>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>> -Strategies to boost innovation and cut costs with open source participation >>> -Receive a $600 discount off the registration fee with the source code: SFAD >>> http://p.sf.net/sfu/XcvMzF8H >>> _______________________________________________ >>> Stellarium-pubdevel mailing list >>> Ste...@li... >>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>> >> >> ------------------------------------------------------------------------------ >> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >> -Strategies to boost innovation and cut costs with open source participation >> -Receive a $600 discount off the registration fee with the source code: SFAD >> http://p.sf.net/sfu/XcvMzF8H >> _______________________________________________ >> Stellarium-pubdevel mailing list >> Ste...@li... >> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Fabien C. <fab...@go...> - 2009-03-03 16:04:18
|
I was thinking to make the release next week. Fabien On Tue, Mar 3, 2009 at 4:24 PM, Mike Storm <oop...@gm...> wrote: > I think it'll have to go 0.10.3, since I don't have time to finish it > at the moment (i.e., within the next 24 hours). > > Mike > > On Tue, Mar 3, 2009 at 5:44 AM, Fabien Chéreau > <fab...@go...> wrote: >> What is the status on this? If we want to include the new feature in >> 0.10.2, it should be committed soon so that we can perform extended >> testing. >> Fabien >> >> On Sat, Feb 28, 2009 at 7:58 PM, Mike Storm <oop...@gm...> wrote: >>> Hi Fabien, >>> >>> Yes, I figured you would say that. I only realized how similar >>> StelSearchMgr and StelObjectMgr were after almost completing the work, >>> but I thought I would just send the patch and merge them later. Your >>> solution is almost exactly what I had in mind. I'll work on it. >>> >>> Mike >>> >>> On Sat, Feb 28, 2009 at 11:09 AM, Fabien Chéreau >>> <fab...@go...> wrote: >>>> Oups, I sent the email by mistake, here is the rest: >>>> >>>> >>>> >>>> On Sat, Feb 28, 2009 at 6:04 PM, Fabien Chéreau >>>> <fab...@go...> wrote: >>>>> OK, >>>>> I had a detailed look at your patch. I like the general idea, and I >>>>> also like you code style and comments. However I think the classes you >>>>> created somewhat mirror the current ones: It looks to me that the >>>>> feature brought by StelSearchMgr should be just new methods added to >>>>> the StelObjectMgr, similariy, the Searcher class feature to allow for >>>>> asynchronous searches could just be merged with the StelObjectModule >>>>> class by adding the necessary method (the lookup() one) >>>>> This design would respect the current stellarium design and avoid >>>>> creating a lot of new API. >>>>> >>>>> The last problem is the management of StelObject created on the fly by >>>>> Simbad lookups, a >>>> >>>> In this case the most natural design would simply to make the >>>> SimbadSearcher derive from StelObjectModule, which would in turn >>>> implement the required search features. It could as well allow to >>>> display the query result visually on the screen, which could be very >>>> useful. >>>> In fact I just realize that this definitely was the proper design to >>>> adopt from the beginning, but could find this out before you did this >>>> good work :) >>>> >>>> What do you think? >>>> >>>> Fabien >>>> >>>>> On Sat, Feb 28, 2009 at 1:23 PM, Fabien Chéreau >>>>> <fab...@go...> wrote: >>>>>> Please wait, >>>>>> I want to have a look before. >>>>>> Fabien >>>>>> >>>>>> On Sat, Feb 28, 2009 at 8:50 AM, Mike Storm <oop...@gm...> wrote: >>>>>>> If there are no objections, I'll go ahead and commit. >>>>>>> >>>>>>> Mike >>>>>>> >>>>>>> On Fri, Feb 27, 2009 at 12:24 PM, Mike Storm <oop...@gm...> wrote: >>>>>>>> That's odd. I must had svn add'ed them after I created the patch. >>>>>>>> Here's an updated version. >>>>>>>> >>>>>>>> Mike >>>>>>>> >>>>>>>> On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: >>>>>>>>> Hi, Mike. >>>>>>>>> >>>>>>>>> It seems that the code for the StelSearchMgr class is not in your >>>>>>>>> patch, so it's impossible to build it. :) >>>>>>>>> >>>>>>>>> Bogdan >>>>>>>>> >>>>>>>>> On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >>>>>>>>>> Hi everyone, >>>>>>>>>> >>>>>>>>>> I worked on a complete redesign of the searching logic behind >>>>>>>>>> SearchDialog, so that it is separated from the UI. This allows several >>>>>>>>>> improvements, the most important of which are: we can very easily add >>>>>>>>>> new data to search, and search results are full StelObjects. To create >>>>>>>>>> a new search method, just subclass Searcher and SearcherReply and call >>>>>>>>>> SearchMgr::addSearcher(Searcher*). This also simplifies the >>>>>>>>>> SearchDialog code greatly. >>>>>>>>>> >>>>>>>>>> I think this way is much more elegant, without any loss in >>>>>>>>>> functionality. Other classes and plugins can now use StelSearchMgr, as >>>>>>>>>> well. I've attached the code as a patch, because I'd rather get some >>>>>>>>>> feedback and approval before committing it. The patch was diff'd >>>>>>>>>> against rev 4298. >>>>>>>>>> >>>>>>>>>> P.S. I only added the "Show details" button as a demo. We can easily >>>>>>>>>> remove it if necessary. >>>>>>>>>> >>>>>>>>>> Cheers, >>>>>>>>>> Mike >>>> >>>> ------------------------------------------------------------------------------ >>>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>>> -Strategies to boost innovation and cut costs with open source participation >>>> -Receive a $600 discount off the registration fee with the source code: SFAD >>>> http://p.sf.net/sfu/XcvMzF8H >>>> _______________________________________________ >>>> Stellarium-pubdevel mailing list >>>> Ste...@li... >>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>> -Strategies to boost innovation and cut costs with open source participation >>> -Receive a $600 discount off the registration fee with the source code: SFAD >>> http://p.sf.net/sfu/XcvMzF8H >>> _______________________________________________ >>> Stellarium-pubdevel mailing list >>> Ste...@li... >>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>> >> >> ------------------------------------------------------------------------------ >> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >> -Strategies to boost innovation and cut costs with open source participation >> -Receive a $600 discount off the registration fee with the source code: SFAD >> http://p.sf.net/sfu/XcvMzF8H >> _______________________________________________ >> Stellarium-pubdevel mailing list >> Ste...@li... >> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Mike S. <oop...@gm...> - 2009-03-03 18:00:23
|
Then maybe I'll give it a go. ;-) Mike On Tue, Mar 3, 2009 at 10:04 AM, Fabien Chéreau <fab...@go...> wrote: > I was thinking to make the release next week. > Fabien > > On Tue, Mar 3, 2009 at 4:24 PM, Mike Storm <oop...@gm...> wrote: >> I think it'll have to go 0.10.3, since I don't have time to finish it >> at the moment (i.e., within the next 24 hours). >> >> Mike >> >> On Tue, Mar 3, 2009 at 5:44 AM, Fabien Chéreau >> <fab...@go...> wrote: >>> What is the status on this? If we want to include the new feature in >>> 0.10.2, it should be committed soon so that we can perform extended >>> testing. >>> Fabien >>> >>> On Sat, Feb 28, 2009 at 7:58 PM, Mike Storm <oop...@gm...> wrote: >>>> Hi Fabien, >>>> >>>> Yes, I figured you would say that. I only realized how similar >>>> StelSearchMgr and StelObjectMgr were after almost completing the work, >>>> but I thought I would just send the patch and merge them later. Your >>>> solution is almost exactly what I had in mind. I'll work on it. >>>> >>>> Mike >>>> >>>> On Sat, Feb 28, 2009 at 11:09 AM, Fabien Chéreau >>>> <fab...@go...> wrote: >>>>> Oups, I sent the email by mistake, here is the rest: >>>>> >>>>> >>>>> >>>>> On Sat, Feb 28, 2009 at 6:04 PM, Fabien Chéreau >>>>> <fab...@go...> wrote: >>>>>> OK, >>>>>> I had a detailed look at your patch. I like the general idea, and I >>>>>> also like you code style and comments. However I think the classes you >>>>>> created somewhat mirror the current ones: It looks to me that the >>>>>> feature brought by StelSearchMgr should be just new methods added to >>>>>> the StelObjectMgr, similariy, the Searcher class feature to allow for >>>>>> asynchronous searches could just be merged with the StelObjectModule >>>>>> class by adding the necessary method (the lookup() one) >>>>>> This design would respect the current stellarium design and avoid >>>>>> creating a lot of new API. >>>>>> >>>>>> The last problem is the management of StelObject created on the fly by >>>>>> Simbad lookups, a >>>>> >>>>> In this case the most natural design would simply to make the >>>>> SimbadSearcher derive from StelObjectModule, which would in turn >>>>> implement the required search features. It could as well allow to >>>>> display the query result visually on the screen, which could be very >>>>> useful. >>>>> In fact I just realize that this definitely was the proper design to >>>>> adopt from the beginning, but could find this out before you did this >>>>> good work :) >>>>> >>>>> What do you think? >>>>> >>>>> Fabien >>>>> >>>>>> On Sat, Feb 28, 2009 at 1:23 PM, Fabien Chéreau >>>>>> <fab...@go...> wrote: >>>>>>> Please wait, >>>>>>> I want to have a look before. >>>>>>> Fabien >>>>>>> >>>>>>> On Sat, Feb 28, 2009 at 8:50 AM, Mike Storm <oop...@gm...> wrote: >>>>>>>> If there are no objections, I'll go ahead and commit. >>>>>>>> >>>>>>>> Mike >>>>>>>> >>>>>>>> On Fri, Feb 27, 2009 at 12:24 PM, Mike Storm <oop...@gm...> wrote: >>>>>>>>> That's odd. I must had svn add'ed them after I created the patch. >>>>>>>>> Here's an updated version. >>>>>>>>> >>>>>>>>> Mike >>>>>>>>> >>>>>>>>> On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: >>>>>>>>>> Hi, Mike. >>>>>>>>>> >>>>>>>>>> It seems that the code for the StelSearchMgr class is not in your >>>>>>>>>> patch, so it's impossible to build it. :) >>>>>>>>>> >>>>>>>>>> Bogdan >>>>>>>>>> >>>>>>>>>> On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >>>>>>>>>>> Hi everyone, >>>>>>>>>>> >>>>>>>>>>> I worked on a complete redesign of the searching logic behind >>>>>>>>>>> SearchDialog, so that it is separated from the UI. This allows several >>>>>>>>>>> improvements, the most important of which are: we can very easily add >>>>>>>>>>> new data to search, and search results are full StelObjects. To create >>>>>>>>>>> a new search method, just subclass Searcher and SearcherReply and call >>>>>>>>>>> SearchMgr::addSearcher(Searcher*). This also simplifies the >>>>>>>>>>> SearchDialog code greatly. >>>>>>>>>>> >>>>>>>>>>> I think this way is much more elegant, without any loss in >>>>>>>>>>> functionality. Other classes and plugins can now use StelSearchMgr, as >>>>>>>>>>> well. I've attached the code as a patch, because I'd rather get some >>>>>>>>>>> feedback and approval before committing it. The patch was diff'd >>>>>>>>>>> against rev 4298. >>>>>>>>>>> >>>>>>>>>>> P.S. I only added the "Show details" button as a demo. We can easily >>>>>>>>>>> remove it if necessary. >>>>>>>>>>> >>>>>>>>>>> Cheers, >>>>>>>>>>> Mike >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>>>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>>>> -Strategies to boost innovation and cut costs with open source participation >>>>> -Receive a $600 discount off the registration fee with the source code: SFAD >>>>> http://p.sf.net/sfu/XcvMzF8H >>>>> _______________________________________________ >>>>> Stellarium-pubdevel mailing list >>>>> Ste...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>>> -Strategies to boost innovation and cut costs with open source participation >>>> -Receive a $600 discount off the registration fee with the source code: SFAD >>>> http://p.sf.net/sfu/XcvMzF8H >>>> _______________________________________________ >>>> Stellarium-pubdevel mailing list >>>> Ste...@li... >>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>> -Strategies to boost innovation and cut costs with open source participation >>> -Receive a $600 discount off the registration fee with the source code: SFAD >>> http://p.sf.net/sfu/XcvMzF8H >>> _______________________________________________ >>> Stellarium-pubdevel mailing list >>> Ste...@li... >>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>> >> >> ------------------------------------------------------------------------------ >> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >> -Strategies to boost innovation and cut costs with open source participation >> -Receive a $600 discount off the registration fee with the source code: SFAD >> http://p.sf.net/sfu/XcvMzF8H >> _______________________________________________ >> Stellarium-pubdevel mailing list >> Ste...@li... >> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Fabien C. <fab...@go...> - 2009-03-06 13:26:51
|
Hi Mike, I think it's OK to keep the patch for next release, it doesn't change the user experience anyway. I would like to release Stellarium ASAP now, maybe during this WE or on Monday. So let's freeze all features and track/remove remaining bugs! Fabien On Tue, Mar 3, 2009 at 7:00 PM, Mike Storm <oop...@gm...> wrote: > Then maybe I'll give it a go. ;-) > > Mike > > On Tue, Mar 3, 2009 at 10:04 AM, Fabien Chéreau > <fab...@go...> wrote: >> I was thinking to make the release next week. >> Fabien >> >> On Tue, Mar 3, 2009 at 4:24 PM, Mike Storm <oop...@gm...> wrote: >>> I think it'll have to go 0.10.3, since I don't have time to finish it >>> at the moment (i.e., within the next 24 hours). >>> >>> Mike >>> >>> On Tue, Mar 3, 2009 at 5:44 AM, Fabien Chéreau >>> <fab...@go...> wrote: >>>> What is the status on this? If we want to include the new feature in >>>> 0.10.2, it should be committed soon so that we can perform extended >>>> testing. >>>> Fabien >>>> >>>> On Sat, Feb 28, 2009 at 7:58 PM, Mike Storm <oop...@gm...> wrote: >>>>> Hi Fabien, >>>>> >>>>> Yes, I figured you would say that. I only realized how similar >>>>> StelSearchMgr and StelObjectMgr were after almost completing the work, >>>>> but I thought I would just send the patch and merge them later. Your >>>>> solution is almost exactly what I had in mind. I'll work on it. >>>>> >>>>> Mike >>>>> >>>>> On Sat, Feb 28, 2009 at 11:09 AM, Fabien Chéreau >>>>> <fab...@go...> wrote: >>>>>> Oups, I sent the email by mistake, here is the rest: >>>>>> >>>>>> >>>>>> >>>>>> On Sat, Feb 28, 2009 at 6:04 PM, Fabien Chéreau >>>>>> <fab...@go...> wrote: >>>>>>> OK, >>>>>>> I had a detailed look at your patch. I like the general idea, and I >>>>>>> also like you code style and comments. However I think the classes you >>>>>>> created somewhat mirror the current ones: It looks to me that the >>>>>>> feature brought by StelSearchMgr should be just new methods added to >>>>>>> the StelObjectMgr, similariy, the Searcher class feature to allow for >>>>>>> asynchronous searches could just be merged with the StelObjectModule >>>>>>> class by adding the necessary method (the lookup() one) >>>>>>> This design would respect the current stellarium design and avoid >>>>>>> creating a lot of new API. >>>>>>> >>>>>>> The last problem is the management of StelObject created on the fly by >>>>>>> Simbad lookups, a >>>>>> >>>>>> In this case the most natural design would simply to make the >>>>>> SimbadSearcher derive from StelObjectModule, which would in turn >>>>>> implement the required search features. It could as well allow to >>>>>> display the query result visually on the screen, which could be very >>>>>> useful. >>>>>> In fact I just realize that this definitely was the proper design to >>>>>> adopt from the beginning, but could find this out before you did this >>>>>> good work :) >>>>>> >>>>>> What do you think? >>>>>> >>>>>> Fabien >>>>>> >>>>>>> On Sat, Feb 28, 2009 at 1:23 PM, Fabien Chéreau >>>>>>> <fab...@go...> wrote: >>>>>>>> Please wait, >>>>>>>> I want to have a look before. >>>>>>>> Fabien >>>>>>>> >>>>>>>> On Sat, Feb 28, 2009 at 8:50 AM, Mike Storm <oop...@gm...> wrote: >>>>>>>>> If there are no objections, I'll go ahead and commit. >>>>>>>>> >>>>>>>>> Mike >>>>>>>>> >>>>>>>>> On Fri, Feb 27, 2009 at 12:24 PM, Mike Storm <oop...@gm...> wrote: >>>>>>>>>> That's odd. I must had svn add'ed them after I created the patch. >>>>>>>>>> Here's an updated version. >>>>>>>>>> >>>>>>>>>> Mike >>>>>>>>>> >>>>>>>>>> On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: >>>>>>>>>>> Hi, Mike. >>>>>>>>>>> >>>>>>>>>>> It seems that the code for the StelSearchMgr class is not in your >>>>>>>>>>> patch, so it's impossible to build it. :) >>>>>>>>>>> >>>>>>>>>>> Bogdan >>>>>>>>>>> >>>>>>>>>>> On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >>>>>>>>>>>> Hi everyone, >>>>>>>>>>>> >>>>>>>>>>>> I worked on a complete redesign of the searching logic behind >>>>>>>>>>>> SearchDialog, so that it is separated from the UI. This allows several >>>>>>>>>>>> improvements, the most important of which are: we can very easily add >>>>>>>>>>>> new data to search, and search results are full StelObjects. To create >>>>>>>>>>>> a new search method, just subclass Searcher and SearcherReply and call >>>>>>>>>>>> SearchMgr::addSearcher(Searcher*). This also simplifies the >>>>>>>>>>>> SearchDialog code greatly. >>>>>>>>>>>> >>>>>>>>>>>> I think this way is much more elegant, without any loss in >>>>>>>>>>>> functionality. Other classes and plugins can now use StelSearchMgr, as >>>>>>>>>>>> well. I've attached the code as a patch, because I'd rather get some >>>>>>>>>>>> feedback and approval before committing it. The patch was diff'd >>>>>>>>>>>> against rev 4298. >>>>>>>>>>>> >>>>>>>>>>>> P.S. I only added the "Show details" button as a demo. We can easily >>>>>>>>>>>> remove it if necessary. >>>>>>>>>>>> >>>>>>>>>>>> Cheers, >>>>>>>>>>>> Mike >>>>>> >>>>>> ------------------------------------------------------------------------------ >>>>>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>>>>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>>>>> -Strategies to boost innovation and cut costs with open source participation >>>>>> -Receive a $600 discount off the registration fee with the source code: SFAD >>>>>> http://p.sf.net/sfu/XcvMzF8H >>>>>> _______________________________________________ >>>>>> Stellarium-pubdevel mailing list >>>>>> Ste...@li... >>>>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>>>>> >>>>> >>>>> ------------------------------------------------------------------------------ >>>>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>>>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>>>> -Strategies to boost innovation and cut costs with open source participation >>>>> -Receive a $600 discount off the registration fee with the source code: SFAD >>>>> http://p.sf.net/sfu/XcvMzF8H >>>>> _______________________________________________ >>>>> Stellarium-pubdevel mailing list >>>>> Ste...@li... >>>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>>>> >>>> >>>> ------------------------------------------------------------------------------ >>>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>>> -Strategies to boost innovation and cut costs with open source participation >>>> -Receive a $600 discount off the registration fee with the source code: SFAD >>>> http://p.sf.net/sfu/XcvMzF8H >>>> _______________________________________________ >>>> Stellarium-pubdevel mailing list >>>> Ste...@li... >>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>>> >>> >>> ------------------------------------------------------------------------------ >>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>> -Strategies to boost innovation and cut costs with open source participation >>> -Receive a $600 discount off the registration fee with the source code: SFAD >>> http://p.sf.net/sfu/XcvMzF8H >>> _______________________________________________ >>> Stellarium-pubdevel mailing list >>> Ste...@li... >>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>> >> >> ------------------------------------------------------------------------------ >> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >> -Strategies to boost innovation and cut costs with open source participation >> -Receive a $600 discount off the registration fee with the source code: SFAD >> http://p.sf.net/sfu/XcvMzF8H >> _______________________________________________ >> Stellarium-pubdevel mailing list >> Ste...@li... >> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Bogdan M. <dag...@gm...> - 2009-03-30 22:00:47
|
Again, prod/reminder: On Fri, Mar 6, 2009 at 4:26 PM, Fabien Chéreau <fab...@go...> wrote: > Hi Mike, > I think it's OK to keep the patch for next release, it doesn't change > the user experience anyway. I would like to release Stellarium ASAP > now, maybe during this WE or on Monday. > So let's freeze all features and track/remove remaining bugs! > Fabien > > On Tue, Mar 3, 2009 at 7:00 PM, Mike Storm <oop...@gm...> wrote: >> Then maybe I'll give it a go. ;-) >> >> Mike >> >> On Tue, Mar 3, 2009 at 10:04 AM, Fabien Chéreau >> <fab...@go...> wrote: >>> I was thinking to make the release next week. >>> Fabien >>> >>> On Tue, Mar 3, 2009 at 4:24 PM, Mike Storm <oop...@gm...> wrote: >>>> I think it'll have to go 0.10.3, since I don't have time to finish it >>>> at the moment (i.e., within the next 24 hours). >>>> >>>> Mike >>>> >>>> On Tue, Mar 3, 2009 at 5:44 AM, Fabien Chéreau >>>> <fab...@go...> wrote: >>>>> What is the status on this? If we want to include the new feature in >>>>> 0.10.2, it should be committed soon so that we can perform extended >>>>> testing. >>>>> Fabien >>>>> >>>>> On Sat, Feb 28, 2009 at 7:58 PM, Mike Storm <oop...@gm...> wrote: >>>>>> Hi Fabien, >>>>>> >>>>>> Yes, I figured you would say that. I only realized how similar >>>>>> StelSearchMgr and StelObjectMgr were after almost completing the work, >>>>>> but I thought I would just send the patch and merge them later. Your >>>>>> solution is almost exactly what I had in mind. I'll work on it. >>>>>> >>>>>> Mike >>>>>> >>>>>> On Sat, Feb 28, 2009 at 11:09 AM, Fabien Chéreau >>>>>> <fab...@go...> wrote: >>>>>>> Oups, I sent the email by mistake, here is the rest: >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Sat, Feb 28, 2009 at 6:04 PM, Fabien Chéreau >>>>>>> <fab...@go...> wrote: >>>>>>>> OK, >>>>>>>> I had a detailed look at your patch. I like the general idea, and I >>>>>>>> also like you code style and comments. However I think the classes you >>>>>>>> created somewhat mirror the current ones: It looks to me that the >>>>>>>> feature brought by StelSearchMgr should be just new methods added to >>>>>>>> the StelObjectMgr, similariy, the Searcher class feature to allow for >>>>>>>> asynchronous searches could just be merged with the StelObjectModule >>>>>>>> class by adding the necessary method (the lookup() one) >>>>>>>> This design would respect the current stellarium design and avoid >>>>>>>> creating a lot of new API. >>>>>>>> >>>>>>>> The last problem is the management of StelObject created on the fly by >>>>>>>> Simbad lookups, a >>>>>>> >>>>>>> In this case the most natural design would simply to make the >>>>>>> SimbadSearcher derive from StelObjectModule, which would in turn >>>>>>> implement the required search features. It could as well allow to >>>>>>> display the query result visually on the screen, which could be very >>>>>>> useful. >>>>>>> In fact I just realize that this definitely was the proper design to >>>>>>> adopt from the beginning, but could find this out before you did this >>>>>>> good work :) >>>>>>> >>>>>>> What do you think? >>>>>>> >>>>>>> Fabien >>>>>>> >>>>>>>> On Sat, Feb 28, 2009 at 1:23 PM, Fabien Chéreau >>>>>>>> <fab...@go...> wrote: >>>>>>>>> Please wait, >>>>>>>>> I want to have a look before. >>>>>>>>> Fabien >>>>>>>>> >>>>>>>>> On Sat, Feb 28, 2009 at 8:50 AM, Mike Storm <oop...@gm...> wrote: >>>>>>>>>> If there are no objections, I'll go ahead and commit. >>>>>>>>>> >>>>>>>>>> Mike >>>>>>>>>> >>>>>>>>>> On Fri, Feb 27, 2009 at 12:24 PM, Mike Storm <oop...@gm...> wrote: >>>>>>>>>>> That's odd. I must had svn add'ed them after I created the patch. >>>>>>>>>>> Here's an updated version. >>>>>>>>>>> >>>>>>>>>>> Mike >>>>>>>>>>> >>>>>>>>>>> On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: >>>>>>>>>>>> Hi, Mike. >>>>>>>>>>>> >>>>>>>>>>>> It seems that the code for the StelSearchMgr class is not in your >>>>>>>>>>>> patch, so it's impossible to build it. :) >>>>>>>>>>>> >>>>>>>>>>>> Bogdan >>>>>>>>>>>> >>>>>>>>>>>> On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >>>>>>>>>>>>> Hi everyone, >>>>>>>>>>>>> >>>>>>>>>>>>> I worked on a complete redesign of the searching logic behind >>>>>>>>>>>>> SearchDialog, so that it is separated from the UI. This allows several >>>>>>>>>>>>> improvements, the most important of which are: we can very easily add >>>>>>>>>>>>> new data to search, and search results are full StelObjects. To create >>>>>>>>>>>>> a new search method, just subclass Searcher and SearcherReply and call >>>>>>>>>>>>> SearchMgr::addSearcher(Searcher*). This also simplifies the >>>>>>>>>>>>> SearchDialog code greatly. >>>>>>>>>>>>> >>>>>>>>>>>>> I think this way is much more elegant, without any loss in >>>>>>>>>>>>> functionality. Other classes and plugins can now use StelSearchMgr, as >>>>>>>>>>>>> well. I've attached the code as a patch, because I'd rather get some >>>>>>>>>>>>> feedback and approval before committing it. The patch was diff'd >>>>>>>>>>>>> against rev 4298. >>>>>>>>>>>>> >>>>>>>>>>>>> P.S. I only added the "Show details" button as a demo. We can easily >>>>>>>>>>>>> remove it if necessary. >>>>>>>>>>>>> >>>>>>>>>>>>> Cheers, >>>>>>>>>>>>> Mike As far as I can recall, only my patch was committed. Is there any progress with this? Regards, Bogdan Marinov |
From: Mike S. <oop...@gm...> - 2009-03-30 22:03:24
|
> As far as I can recall, only my patch was committed. Is there any > progress with this? This thing? I got distracted/it's not a high priority. Do you need it for something? Mike |
From: Bogdan M. <dag...@gm...> - 2009-03-30 22:35:51
|
On Tue, Mar 31, 2009 at 1:03 AM, Mike Storm <oop...@gm...> wrote: >> As far as I can recall, only my patch was committed. Is there any >> progress with this? > > This thing? I got distracted/it's not a high priority. Do you need it > for something? Nope. I was cleaning up my Inbox and the thread came up, so I decided to ask if there's any progress. :) Bogdan |