From: Fabien C. <fab...@go...> - 2009-02-28 13:23:57
|
Please wait, I want to have a look before. Fabien On Sat, Feb 28, 2009 at 8:50 AM, Mike Storm <oop...@gm...> wrote: > If there are no objections, I'll go ahead and commit. > > Mike > > On Fri, Feb 27, 2009 at 12:24 PM, Mike Storm <oop...@gm...> wrote: >> That's odd. I must had svn add'ed them after I created the patch. >> Here's an updated version. >> >> Mike >> >> On Fri, Feb 27, 2009 at 6:36 AM, Bogdan Marinov <dag...@gm...> wrote: >>> Hi, Mike. >>> >>> It seems that the code for the StelSearchMgr class is not in your >>> patch, so it's impossible to build it. :) >>> >>> Bogdan >>> >>> On Fri, Feb 27, 2009 at 5:16 AM, Mike Storm <oop...@gm...> wrote: >>>> Hi everyone, >>>> >>>> I worked on a complete redesign of the searching logic behind >>>> SearchDialog, so that it is separated from the UI. This allows several >>>> improvements, the most important of which are: we can very easily add >>>> new data to search, and search results are full StelObjects. To create >>>> a new search method, just subclass Searcher and SearcherReply and call >>>> SearchMgr::addSearcher(Searcher*). This also simplifies the >>>> SearchDialog code greatly. >>>> >>>> I think this way is much more elegant, without any loss in >>>> functionality. Other classes and plugins can now use StelSearchMgr, as >>>> well. I've attached the code as a patch, because I'd rather get some >>>> feedback and approval before committing it. The patch was diff'd >>>> against rev 4298. >>>> >>>> P.S. I only added the "Show details" button as a demo. We can easily >>>> remove it if necessary. >>>> >>>> Cheers, >>>> Mike >>>> >>>> ------------------------------------------------------------------------------ >>>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>>> -Strategies to boost innovation and cut costs with open source participation >>>> -Receive a $600 discount off the registration fee with the source code: SFAD >>>> http://p.sf.net/sfu/XcvMzF8H >>>> _______________________________________________ >>>> Stellarium-pubdevel mailing list >>>> Ste...@li... >>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>>> >>>> >>> >>> ------------------------------------------------------------------------------ >>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA >>> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise >>> -Strategies to boost innovation and cut costs with open source participation >>> -Receive a $600 discount off the registration fee with the source code: SFAD >>> http://p.sf.net/sfu/XcvMzF8H >>> _______________________________________________ >>> Stellarium-pubdevel mailing list >>> Ste...@li... >>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >>> >> > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |