Re: [Stellarium-pubdevel] Add/remove landscapes feature

[Fabien C. <fab...@go...>]

Hi Bogdan,

On Sun, Sep 5, 2010 at 14:58, Bogdan Marinov <dag...@gm...> wrote:
> Hello to all.
>
> I've merged my experimental AddRemoveLandscapes plug-in to the core
> code. The branch is here:
> https://code.launchpad.net/~daggerstab/stellarium/add-remove-landscapes
>
> The code went to the LandscapeMgr class and a sub-window of the Sky
> and viewing options window (ViewDialog), with minimal changes to
> ViewDialog itself. Now there is a "Add/remove landscapes..." button in
> the Landscapes tab that opens the sub-window.
>
> It's not ready for merging yet (there is some more work on my other
> computer that I need to merge), but comments and suggestions are
> welcome. Bug reports too. :)

I just had a look through your code, and I think it's good :)  Don't
forget to make the user's visible strings translatable (and add the
file in the po/stellarium/POTFILES.in).

> A minor issue that I am unsure about is line 315 (now 322) in
> ViewDialog.cpp (see this diff link:
> http://bazaar.launchpad.net/~daggerstab/stellarium/add-remove-landscapes/revision/4746#src/gui/ViewDialog.cpp
> ). It seems to work OK with my changes.

I have no clue.. If it works I guess it's fine.

> At the moment, LandscapeMgr does not protect the default landscapes
> from being deleted. They are excluded from the list in the GUI, but I
> don't think that this is enough protection. Also, the list of default
> landscapes needs to be updated manually. I'll try to have it generated
> by CMake.

Maybe it would be cleaner to just add a special parameter in the
landscape.ini file, e.g. readonly = true
I would prefer to avoid cmake preprocessing as much as possible so
that we are able to migrate to another build system in a longer term
(e.g. qmake).

Thanks! When you feel it's ready for merging, just use the LP feature,
and I will accept it.
Fab

> Regards,
> Bogdan Marinov
>
> ------------------------------------------------------------------------------
> This SF.net Dev2Dev email is sponsored by:
>
> Show off your parallel programming skills.
> Enter the Intel(R) Threading Challenge 2010.
> http://p.sf.net/sfu/intel-thread-sfd
> _______________________________________________
> Stellarium-pubdevel mailing list
> Ste...@li...
> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
>