Re: [Stellarium-pubdevel] Fix memory mapping crash on Windows patch

[F. C. <fab...@go...>]

On Tue, Dec 16, 2008 at 12:37 PM, Mike Storm <oop...@gm...> wrote:
> On Tue, Dec 16, 2008 at 5:20 AM, Fabien Chéreau
> <fab...@go...> wrote:
>> On Tue, Dec 16, 2008 at 11:51 AM, Mike Storm <oop...@gm...> wrote:
>>> Hi Fabien,
>>> Thanks! Sorry, I didn't mean to be impatient. I do indeed want to dig
>>> in more, but I'm occupied with a few other tasks at the moment.
>>
>> Don't worry! I like impatient people :)
>>
>>> Several people on the forums reported the bug, so I wanted to fix it
>>> as soon as possible. Unfortunately, now a separate problem with memory
>>> mapping has cropped up on Windows
>>> (https://sourceforge.net/forum/forum.php?thread_id=2683933&forum_id=278769).
>>> Not as serious as the QFile::map() segfault, but annoying nonetheless.
>>> And since I can't reproduce it, I don't know if I can fix it.
>>
>> Yeah I saw this one too, I am wondering if the guy just didn't have
>> download errors.. The file is quite big. He should maybe md5sum check
>> his file.
>
> gammaburst says that he downloaded it a few days before this problem
> occurred. I think he's implying that he had 0.9.1 and it was working,
> then upgraded to 0.10.0 and copied the catalog over. Why didn't I
> think of that before? If it was working in 0.9.1, we can track down
> the change between versions. I'll ask in the morning. (My sleep
> schedule is somehow on New Zealand time.)

haha :) Where do you live? In US?
Fab

>>
>> Fabien
>>
>>> Like you
>>> said, the best solution is to make the code platform-independent and
>>> uniform.
>>>
>>> Mike
>>>
>>> On Tue, Dec 16, 2008 at 4:22 AM, Fabien Chéreau
>>> <fab...@go...> wrote:
>>>> OK, Applied.
>>>> Fabien
>>>>
>>>> On Tue, Dec 16, 2008 at 11:21 AM, Fabien Chéreau
>>>> <fab...@go...> wrote:
>>>>> Hi Mike,
>>>>> Sorry for the unresponsiveness! OK, I will apply your patch now, I
>>>>> didn't do it before because I thought you wanted to dig in more.
>>>>> Indeed it would be nice to find out why this happens, and make the
>>>>> code more uniform.
>>>>> Fabien
>>>>>
>>>>> On Mon, Dec 15, 2008 at 11:37 PM, Mike Storm <oop...@gm...> wrote:
>>>>>> Is there something keeping this fix from being applied? It would be a
>>>>>> great comfort to know my code isn't causing Windows machines to
>>>>>> segfault anymore :-).
>>>>>>
>>>>>> Mike
>>>>>>
>>>>>> On Sat, Dec 13, 2008 at 11:28 PM, Mike Storm <oop...@gm...> wrote:
>>>>>>> Hi all,
>>>>>>>
>>>>>>> Barry Gerdes reported in this forum post:
>>>>>>> https://sourceforge.net/forum/forum.php?thread_id=2622985&forum_id=278769
>>>>>>> that several Windows boxes of his crashed when zooming in on stars
>>>>>>> that were memory mapped using the new QFile::map() method. I haven't
>>>>>>> figured out why this happens yet, but I've attached a patch that
>>>>>>> causes Windows builds to use the old mmap() function. Linux and Mac
>>>>>>> still use the new QFile::map() method. I finally got Stellarium to
>>>>>>> build on my Windows dual-boot, so it's tested on XP SP3 and Linux.
>>>>>>>
>>>>>>> Fabien, you said in the original thread for the ZoneArray patch that
>>>>>>> you tested a Windows build, and it worked. Do you know what the system
>>>>>>> specs on that machine were? And did you zoom in on the large memory
>>>>>>> mapped catalogs? Apparently, it only crashes when you do that.
>>>>>>>
>>>>>>> Mike
>>>>>>>
>>>>>>
>>>>>> ------------------------------------------------------------------------------
>>>>>> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
>>>>>> The future of the web can't happen without you.  Join us at MIX09 to help
>>>>>> pave the way to the Next Web now. Learn more and register at
>>>>>> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
>>>>>> _______________________________________________
>>>>>> Stellarium-pubdevel mailing list
>>>>>> Ste...@li...
>>>>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
>>>>>>
>>>>>
>>>>
>>>> ------------------------------------------------------------------------------
>>>> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
>>>> The future of the web can't happen without you.  Join us at MIX09 to help
>>>> pave the way to the Next Web now. Learn more and register at
>>>> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
>>>> _______________________________________________
>>>> Stellarium-pubdevel mailing list
>>>> Ste...@li...
>>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
>>>>
>>>
>>> ------------------------------------------------------------------------------
>>> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
>>> The future of the web can't happen without you.  Join us at MIX09 to help
>>> pave the way to the Next Web now. Learn more and register at
>>> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
>>> _______________________________________________
>>> Stellarium-pubdevel mailing list
>>> Ste...@li...
>>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
>>>
>>
>> ------------------------------------------------------------------------------
>> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
>> The future of the web can't happen without you.  Join us at MIX09 to help
>> pave the way to the Next Web now. Learn more and register at
>> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
>> _______________________________________________
>> Stellarium-pubdevel mailing list
>> Ste...@li...
>> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
>>
>
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
> The future of the web can't happen without you.  Join us at MIX09 to help
> pave the way to the Next Web now. Learn more and register at
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> _______________________________________________
> Stellarium-pubdevel mailing list
> Ste...@li...
> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
>