Re: [Stellarium-pubdevel] win32 directories

[Matthew G. <mat...@gm...>]

Ah, there it is.  Well done, I missed that.  I'll have a look at it 
tomorrow.

On Tuesday 18 November 2008, Steve Ingamells wrote:
> Hi Matthew,
>
> The error is:
>
> WARNING StelFileMgr::setScreenshotDir dir is not writable: [followed by
> the Desktop folder path]
>
> Followed by a runtime termination message.
>
> See screenshot attached...
>
> The code for setScreenshotDir, which is where the error is coming from,
> is:
>
> void StelFileMgr::setScreenshotDir(const QString& newDir)
> {
>  QFileInfo userDirFI(newDir);
>  if (!userDirFI.exists() || !userDirFI.isDir())
>  {
>   qWarning() << "WARNING StelFileMgr::setScreenshotDir dir does not
> exist: " << userDirFI.filePath();
>   throw (std::runtime_error("NOT_VALID"));
>  }
>  else if (!userDirFI.isWritable())
>  {
>   qWarning() << "WARNING StelFileMgr::setScreenshotDir dir is not
> writable: "
>              << userDirFI.filePath();
>   throw (std::runtime_error("NOT_VALID"));
>  }
>  screenshotDir = userDirFI.filePath();
> }
>
> It's the "throw (std::runtime_error("NOT_VALID"));" that appears to be
> causing the termination, and I assumed that Fabien had recoded it
> recently, as the rev 3915 build was the first that gave this problem on
> my client's Vista PC...
>
> The path to the Desktop folder is correct, as far as I know.
>
> All the best,
> Steve
>
> ________________________________
>
> 	From: Matthew Gates [mailto:mat...@gm...]
> 	Sent: Tuesday, November 18, 2008 9:56 PM
> 	To: St...@in...; Stellarium developers public mailing list
> 	Subject: Re: [Stellarium-pubdevel] win32 directories
>
>
>
> 	This is a weird one. There was a post in the forums about it too,
> also on a Vista box. I don't know what is going on. As far as I can tell,
> the program should simply issue a warning using qWarning(), and then only
> when a screenshot it taken.
>
> 		Perhaps the win32 API call we use to get the Desktop
> directory under windows no longer works in Vista, and causes the crash.
> The call is in StelFileMgr::getDesktopDir(), and is this windows API
> call:
>
> 		getWin32SpecialDirPath(CSIDL_DESKTOPDIRECTORY);
>
> 		If anyone can somehow verify this it would be very helpful -
> I don't have access to a Vista machine on which to test it.
>
> 		If my guess is correct, then I suppose we need some
> conditional compilation section specifically for Vista which will use a
> different mechanism to get the Desktop. Better still (given that most
> installations will be set so that user access controls prevent Stellarium
> writing to the Desktop anyhow), have the default screenshot directory
> something other than the desktop on Vista machines. If we do this, we
> need to work out a sane place for the default, and for that we need a
> Vista user to help us make a good decision.
>
> 		Matthew
>
> 		On Tuesday 18 November 2008, Steve Ingamells wrote:
> 	> Hi Fabien, Matthew, and others...
> 	>
> 	>
> 	>
> 	> I notice that (at rev 3915) Stellarium will force a runtime
>
> termination
>
> 	> if the screenshot folder is not writable, which seems a bit harsh
>
> to me -
>
> 	> I'm running XP and it's fine but my client on the cruise ship
>
> found this
>
> 	> when I sent him a new build, and he's using Vista. He doesn't want
>
> to
>
> 	> make screenshots but he does want to use the application
> 	>
> 	>
> 	>
> 	> I know that the user can either make the Desktop writable or edit
>
> the
>
> 	> config.ini but I would have thought it would be kinder to issue
>
> the
>
> 	> warning and carry on running rather than throw a runtime
>
> termination. :-)
>
> 	> If there's a more important reason for this then I understand.
> 	>
> 	>
> 	>
> 	> Best regards,
> 	>
> 	> Steve Ingamells
>
> -------------------------------------------------------------------------
>
> 	> This SF.Net email is sponsored by the Moblin Your Move Developer's
> 	>
> 	> challenge Build the coolest Linux based applications with Moblin
>
> SDK &
>
> 	> win great prizes Grand prize is a trip for two to an Open Source
>
> event
>
> 	> anywhere in the world
> 	>
> 	> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> 	>
> 	> _______________________________________________
> 	>
> 	> Stellarium-pubdevel mailing list
> 	>
> 	> Ste...@li...
> 	>
> 	> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel