Re: [sstorm-discuss] Re : Fix to the php libs

[Idan S. <i_...@ya...>]

On 17 Jun 2001 22:24:28 -0500, Steven wrote:
> Cool, I woke up this morning and niticed tha annocement on freshmeat, then
> looked at the check-in.
> 
> I now have a new suggestion/question. This snippit is from
> sstorm-dist/lib/php/xmlrpc.inc, lines 490-505. Wouldn't it be just as effective
> to use eregi instead of substr_count for both of your if statements below? I

Donno. Most of xmlrpc.inc was is coming from usefulinc, and i mostly
stayed away from their parsing code, and mostly dealt with high-level
abstraction.

[Looking at the code]

Oh, this is part of the code I did hack around:)

> if(!($head=fgets($fp,4096))) die("Invalid response format");
> At least this way it doesn't hang in the while(1) loop until the execution time

Good point. I'll work a bit on cases where the loop should be broken,
hopefully eliminating at least some of the blocking issues.




Idan.