[SSI-devel] Re: [PATCH] logrotate.c

[John B. <joh...@hp...>]

Aneesh Kumar K.V wrote:
> Hi John,
> 
> I was looking at logrotate pacakge. What do  you think about the below 
> changes. I guess this change should handle all the logs for us.
> 
> -aneesh

This keeps it from breaking the symlink, which is good and should 
probably be checked in for the moment, but it is not totally correct.

wtmp is special. /var/log is a CDSL and we have a symlink for wtmp in 
each one to make it global instead of per-node I tweaked the 
logrotate.conf to rotate /cluster/var/log/wtmp. This keeps the CDSL from 
breaking; however, this doesn't leave wtmp.1 in the per-node /var/log.

Ideally, what logrotate should do in this case is make wtmp.1 in the 
global directory and make symlinks in each node's /var/log to it.

Everthing else in /etc/logrotate.d on my RH system is dealing with 
/var/log and we need it to perform any operations in all the per-node 
/var/log directories.

So for each file logrotate rotates:

Is it really in the /cluster global directory? If so, rotate it there 
and make symlinks.

Is it really in a /cluster/node directory? If so, rotate it each directory.

Otherwise, rotate it normally.

Note that at the moment, comparing files identity by dev and inode 
really doesn't work 100% reliably under SSI because device-numbers are 
not unique across the cluster. We tried exposing a unique mount device 
and had problems with lilo and we didn't want to fix it at the time. 
Since we seem to be happy to keep modifying base apps to work with "SSI" 
these days, perhaps it is time to do so now.

John