Re: [SSI-devel] [PATCH] CVS SSI-1.1.1 FC nfs-utils - rpc.statd failure to start during init

[Brian J. W. <Bri...@hp...>]

Good catch, Roger. This was probably a mistake in the initial merge of 
OpenSSI to FC2. I've checked in your fix.

Thanks,

Brian


Roger Tsang wrote:
> Apply the attached patch to fix rpc.statd failure to startup using
> /etc/init.d/nfslock.
> 
> I've upgraded to nfs-utils-1.0.6-22_ssi_1devel from CVS for SSI-1.1.1 FC,
> but there is a bug in rpc.statd command-line option -C which should take
> no arguments.  On service nfslock start you'll see the following in the
> system log, but rpc.statd quietly exits.
> 
> Dec  4 15:12:54 node1 nfslock: rpc.lockd startup succeeded
> Dec  4 15:12:54 node1 rpc.statd: rpc.statd: option requires an argument -- C
> Dec  4 15:12:54 node1 rpc.statd: usage: rpc.statd [options]
> Dec  4 15:12:54 node1 rpc.statd:       -h, -?, --help       Print this
> help screen.
> Dec  4 15:12:54 node1 rpc.statd:       -F, --foreground     Foreground
> (no-daemon mode)
> Dec  4 15:12:54 node1 rpc.statd:       -d, --no-syslog      Verbose
> logging to stderr.  Foreground mode only.
> Dec  4 15:12:54 node1 rpc.statd:       -p, --port           Port to listen on
> Dec  4 15:12:54 node1 rpc.statd:       -o, --outgoing-port  Port for
> outgoing connections
> Dec  4 15:12:54 node1 rpc.statd:       -V, -v, --version    Display
> version information and exit.
> Dec  4 15:12:54 node1 rpc.statd:       -n, --name           Specify a
> local hostname.
> Dec  4 15:12:54 node1 rpc.statd:       -P                   State
> directory path.
> Dec  4 15:12:54 node1 rpc.statd:       -N                   Run in notify
> only mode.
> Dec  4 15:12:54 node1 rpc.statd:       -C                   Operate
> cluster NFS
> server
> Dec  4 15:12:54 node1 nfslock: rpc.statd startup succeeded
> 
> 
> ------------------------------------------------------------------------
> 
> --- statd.c.orig	2004-12-04 15:30:47.000000000 -0500
> +++ statd.c	2004-12-04 15:31:03.000000000 -0500
> @@ -264,7 +264,7 @@
>  	ssi = cluster_ssiconfig();
>  
>  	/* Process command line switches */
> -	while ((arg = getopt_long(argc, argv, "h?vVFNdn:p:o:P:C:", longopts, NULL)) != EOF) {
> +	while ((arg = getopt_long(argc, argv, "Ch?vVFNdn:p:o:P:", longopts, NULL)) != EOF) {
>  		switch (arg) {
>  		case 'V':	/* Version */
>  		case 'v':