Re: Authenticated SMTP

[Luke E. <leh...@cs...>]

Good call.. :)


On Fri, 13 Apr 2001, Tyler Akins wrote:

> > --- smtp.php	2001/04/10 14:36:03	1.104
> > +++ smtp.php	2001/04/13 15:25:01	1.105
> > @@ -345,10 +345,28 @@
> >        $cc_list = getLineOfAddrs($cc);
> >  
> >        /** Lets introduce ourselves */
> > +      if (! isset ($use_authenticating_smtp)) {
> >        fputs($smtpConnection, "HELO $domain\r\n");
> >        $tmp = fgets($smtpConnection, 1024);
> >        errorCheck($tmp, $smtpConnection);
> 
> This little section got me worried.  You might wish to change it to be
> 
>     if (! isset($use_authenticating_smtp) || ! $use_authenticating_smtp) {
> 
> since it could be set, but still be false.
> 
> (no CVS access for me right now)
> 
> 
> 

-- 
    _
   . .   Luke Ehresman - "Codito, ergo sum"
 /  v  \  lu...@sq...
/(     )\  http://www.css.tayloru.edu/~lehresma
  ^^ ^^