From: Luke E. <leh...@cs...> - 2000-10-03 17:48:49
|
The new attachment support in that patch is very cool! I REALLY like it, especially the plugin support for attachments -- very clever! I have a suggestion though. I didn't look at the code too closely, but how easy is it for people to add new mime types? What if we had a subdir of the plugin that had different mime types. If a directory exists, it runs the code for the speicific mime type. For example, for image/jpeg: attachment_plugin/mime_types/image/jpeg/code.php a problem with this is that most of the code would be the same for all images, so what if we had one for the first part "image", which can handle specific types if needed. Example: attachment_plugin/mime_types/image/code.php attachment_plugin/mime_types/image/jpeg.php I'm just rambling, but that might make it easier to add new mime types.. Thanks for your work.. I think you could probably go ahead and commit that to CVS. It's on our todo list anyway, so you could mark it off as well. :) Luke _ . . Luke Ehresman - "Codito, ergo sum" / v \ lu...@sq... /( )\ http://www.css.tayloru.edu/~lehresma ^^ ^^ |