Re: [SM-DEVEL] Patch for X-SMTP headers support in Squirrelmal (SVN devel branch).

[Paul L. <pa...@sq...>]

On Jan 24, 2008 5:36 AM, Thierry Godefroy <mel...@ya...> wrote:
> On Thu, 24 Jan 2008 12:10:23 +0100
> Thijs Kinkhorst <ki...@sq...> wrote:
>
> > > Would anyone mind if I build the plugin architecture for this? I
> > > think it's something like three more hooks needed. Is it that
> > > terrible that we place such hooks in Rfc822Header.class.php?
> >
> > I think that's just fine and it would be great if you could work on
> > this. Maybe we can just have a hook that allows you to specify a list
> > of extra headers to grab?
>
> The few necessary changes already exist in the patches I just submitted:
>
> In squirrelmail-20080115-SVN_devel-MelindaHooks.patch:
>
>
> diff -urN squirrelmail/functions/mailbox_display.php
> squirrelmail-patched/functions/mailbox_display.php
> --- squirrelmail/functions/mailbox_display.php  2008-01-15 16:34:31.000000000
> +0100
> +++ squirrelmail-patched/functions/mailbox_display.php  2008-01-24
> 10:01:37.000000000 +0100
> @@ -315,6 +315,9 @@
>        }
>      }
>
> +    // For X-SMTP headers we could need to fetch:
> +    do_hook('fetch_more_headers', &$aHeaderFields);
> +
>      /**
>       * A uidset with sorted uid's is available. We can use the cache
>       */

Along with the other part of the original patch I agree with, I think
this one is also correct and should be added.  I would add them now,
but I don't want to step on Alexandros' toes.  (but I cannot imagine a
more simple way to handle this...?  Alexandros, are you doing
something different/more complex?)