From: <ki...@us...> - 2007-09-04 09:33:12
|
Revision: 12671 http://squirrelmail.svn.sourceforge.net/squirrelmail/?rev=12671&view=rev Author: kink Date: 2007-09-04 02:33:10 -0700 (Tue, 04 Sep 2007) Log Message: ----------- fix strict js/css notices (#1778815) Modified Paths: -------------- trunk/squirrelmail/plugins/message_details/message_details_bottom.php trunk/squirrelmail/plugins/newmail/functions.php trunk/squirrelmail/src/login.php trunk/squirrelmail/templates/default/js/default.js trunk/squirrelmail/templates/default/read_toolbar.tpl Modified: trunk/squirrelmail/plugins/message_details/message_details_bottom.php =================================================================== --- trunk/squirrelmail/plugins/message_details/message_details_bottom.php 2007-09-03 11:51:57 UTC (rev 12670) +++ trunk/squirrelmail/plugins/message_details/message_details_bottom.php 2007-09-04 09:33:10 UTC (rev 12671) @@ -287,7 +287,6 @@ $xtra = <<<ECHO <style type="text/css"> - <!-- .ent_body { display:inline; @@ -301,8 +300,7 @@ display:inline; width:99%; } -//--> - +--> </style> ECHO; Modified: trunk/squirrelmail/plugins/newmail/functions.php =================================================================== --- trunk/squirrelmail/plugins/newmail/functions.php 2007-09-03 11:51:57 UTC (rev 12670) +++ trunk/squirrelmail/plugins/newmail/functions.php 2007-09-04 09:33:10 UTC (rev 12671) @@ -234,7 +234,8 @@ if ($newmail_changetitle) { echo "<script type=\"text/javascript\">\n" . - "function ChangeTitleLoad() {\n"; + "function ChangeTitleLoad() {\n" . + "var BeforeChangeTitle;\n"; echo 'window.parent.document.title = "' . sprintf(ngettext("%s New Message","%s New Messages",$totalNew), $totalNew) . "\";\n"; Modified: trunk/squirrelmail/src/login.php =================================================================== --- trunk/squirrelmail/src/login.php 2007-09-03 11:51:57 UTC (rev 12670) +++ trunk/squirrelmail/src/login.php 2007-09-04 09:33:10 UTC (rev 12671) @@ -68,7 +68,7 @@ $header = "<script type=\"text/javascript\">\n" . "<!--\n". " function squirrelmail_loginpage_onload() {\n". - " var textElements = 0;\n". + " var textElements = 0; var i = 0;\n". " for (i = 0; i < document.forms[0].elements.length; i++) {\n". " if (document.forms[0].elements[i].type == \"text\" || document.forms[0].elements[i].type == \"password\") {\n". " textElements++;\n". Modified: trunk/squirrelmail/templates/default/js/default.js =================================================================== --- trunk/squirrelmail/templates/default/js/default.js 2007-09-03 11:51:57 UTC (rev 12670) +++ trunk/squirrelmail/templates/default/js/default.js 2007-09-04 09:33:10 UTC (rev 12671) @@ -15,7 +15,7 @@ * @param string the name of the checkbox that should be (un)checked */ function row_click(chkboxName) { - chkbox = document.getElementById(chkboxName); + var chkbox = document.getElementById(chkboxName); if (chkbox) { // initialize orig_row_color if not defined already if (!orig_row_colors[chkboxName]) { @@ -33,6 +33,7 @@ */ function getCSSClass (theRow) { + var rowClass; // 3.1 ... with DOM compatible browsers except Opera that does not return // valid values with "getAttribute" if (typeof(window.opera) == 'undefined' @@ -65,7 +66,8 @@ * need to predefine the entire array */ function rowOver(chkboxName) { - chkbox = document.getElementById(chkboxName); + var chkbox = document.getElementById(chkboxName); + var rowClass, rowNum, overClass, clickedClass; if (chkbox) { if (!orig_row_colors[chkboxName]) { rowClass = getCSSClass(chkbox.parentNode.parentNode); @@ -95,8 +97,8 @@ * @param string new color of the checked rows */ function toggle_all(formname, fancy) { - TargetForm = document.getElementById(formname); - j = 0; + var TargetForm = document.getElementById(formname); + var j = 0; for (var i = 0; i < TargetForm.elements.length; i++) { if (TargetForm.elements[i].type == 'checkbox' && TargetForm.elements[i].name.substring(0,3) == 'msg') { if (fancy) { @@ -213,7 +215,7 @@ } if (!iWidth) iWidth = 640; if (!iHeight) iHeight = 550; - sArg = "width=" + iWidth + ",height=" + iHeight + ",scrollbars=yes,resizable=yes,status=yes"; + var sArg = "width=" + iWidth + ",height=" + iHeight + ",scrollbars=yes,resizable=yes,status=yes"; var newwin = window.open(comp_uri, "_blank", sArg); } @@ -228,7 +230,7 @@ * Reload the read_body screen on sending an mdn receipt */ function sendMDN() { - mdnuri=window.location+'&sendreceipt=1'; + var mdnuri=window.location+'&sendreceipt=1'; window.location = mdnuri; } Modified: trunk/squirrelmail/templates/default/read_toolbar.tpl =================================================================== --- trunk/squirrelmail/templates/default/read_toolbar.tpl 2007-09-03 11:51:57 UTC (rev 12670) +++ trunk/squirrelmail/templates/default/read_toolbar.tpl 2007-09-04 09:33:10 UTC (rev 12671) @@ -40,7 +40,7 @@ <script type="text/javascript"> <!-- function printFormat () { - print_win = window.open("../src/printer_friendly_main.php<?php echo $link['URL']; ?>", "Print", "width=800; height=600"); + var print_win = window.open("../src/printer_friendly_main.php<?php echo $link['URL']; ?>", "Print", "width=800; height=600"); print_win.focus(); } // --> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |